feat(opensearch): add OpenSearch 2.13 engine version #30399

timbru31 · 2024-05-31T10:28:19Z

Reason for this change

Amazon OpenSearch Service now supports OpenSearch version 2.13

Description of changes

Adds support for OpenSearch engine version 2.13

Description of how you validated changes

yarn test

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

timbru31 · 2024-05-31T10:40:42Z

Exemption Request

Other PRs did not change the README either when the new engine versions were being added.

cowsandmilk · 2024-06-05T17:43:52Z

packages/aws-cdk-lib/aws-opensearchservice/lib/version.ts

-   * AWS OpenSearch 2.10
+   * AWS OpenSearch 2.11
   * @deprecated use latest version of the OpenSearch engine
   **/
-  public static readonly OPENSEARCH_2_10 = EngineVersion.openSearch('2.10');
-
-  /** AWS OpenSearch 2.11 */
  public static readonly OPENSEARCH_2_11 = EngineVersion.openSearch('2.11');


why are you moving 2.11 to being deprecated instead of 2.10?

2.10 is deprecated because it is not a supported opensearch version in Amazon OpenSearch Service. See its absence on https://docs.aws.amazon.com/opensearch-service/latest/developerguide/supported-operations.html . It should remain deprecated and 2.11 should not be deprecated.

Thanks for the documentation hint, I've updated the changes accordingly.

TheRealAmazonKendra · 2024-06-05T20:44:28Z

Excuse me pr bot, an exemption request was added here. Label it! (This is me testing my fix)

TheRealAmazonKendra · 2024-06-05T20:49:21Z

Good PR Bot

TheRealAmazonKendra

Thank you for your contribution! Just a couple of comments:

Integration test changes shouldn't remove coverage from older versions, we still need those tested against as long as customers can still use them.

Also, are all configuration properties valid for 2.13 or are there limitations? If not, we will need to validate for them in code and add those limitation to the README.

timbru31 · 2024-06-10T13:02:43Z

Thank you for your contribution! Just a couple of comments:

Integration test changes shouldn't remove coverage from older versions, we still need those tested against as long as customers can still use them.

Also, are all configuration properties valid for 2.13 or are there limitations? If not, we will need to validate for them in code and add those limitation to the README.

Hi Kendra,
I've updated the version in the integration tests as the previous PR (https://github.com/aws/aws-cdk/pull/28109/files#diff-3f816d35b99012305de1195d096d4315ed0058906a20f09202b742a73b3e4bcdR25) also did. If you'd like I can leave them untouched and only update packages/aws-cdk-lib/aws-opensearchservice/test/domain.test.ts - please let me know.

Also I am not aware of any changes in 2.13 that should cause issues with the properties.

TheRealAmazonKendra · 2024-06-11T20:33:22Z

Thank you for your contribution! Just a couple of comments:
Integration test changes shouldn't remove coverage from older versions, we still need those tested against as long as customers can still use them.
Also, are all configuration properties valid for 2.13 or are there limitations? If not, we will need to validate for them in code and add those limitation to the README.

Hi Kendra, I've updated the version in the integration tests as the previous PR (https://github.com/aws/aws-cdk/pull/28109/files#diff-3f816d35b99012305de1195d096d4315ed0058906a20f09202b742a73b3e4bcdR25) also did. If you'd like I can leave them untouched and only update packages/aws-cdk-lib/aws-opensearchservice/test/domain.test.ts - please let me know.

Also I am not aware of any changes in 2.13 that should cause issues with the properties.

You definitely made a fair assumption that we'd want the same thing again here. I typically prefer to see additional integ tests added instead of updating the old ones, but I'll let this one go in this case (watch this very comment come back to bite me at some point, lol).

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

mergify · 2024-06-11T21:40:20Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-06-11T22:14:06Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 14a1364
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-06-11T22:14:26Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

### Reason for this change [Amazon OpenSearch Service now supports OpenSearch version 2.13](https://aws.amazon.com/about-aws/whats-new/2024/05/amazon-opensearch-supports-opensearch-version-2-13/) ### Description of changes Adds support for OpenSearch engine version 2.13 ### Description of how you validated changes `yarn test` ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

aws-cdk-automation · 2024-07-25T20:50:07Z

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label May 31, 2024

aws-cdk-automation requested a review from a team May 31, 2024 10:28

github-actions bot added the p2 label May 31, 2024

aws-cdk-automation previously requested changes May 31, 2024

View reviewed changes

timbru31 force-pushed the feat/os-2.13 branch from 0815f69 to 7409927 Compare May 31, 2024 10:34

timbru31 changed the title ~~feat(opensearch): OpenSearch 2.13 engine version~~ feat(opensearch): adds OpenSearch 2.13 engine version May 31, 2024

timbru31 force-pushed the feat/os-2.13 branch from 7409927 to 5953449 Compare May 31, 2024 12:08

This was referenced Jun 1, 2024

Monthly PR metrics report #30414

Closed

Weekly PR metrics report #30434

Closed

cowsandmilk reviewed Jun 5, 2024

View reviewed changes

aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jun 5, 2024

TheRealAmazonKendra requested changes Jun 5, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 5, 2024

timbru31 added 2 commits June 10, 2024 14:59

feat(opensearch): adds OpenSearch 2.13 engine version

672dca5

fix: address review feedback

ab423c1

timbru31 force-pushed the feat/os-2.13 branch from 5953449 to ab423c1 Compare June 10, 2024 12:59

TheRealAmazonKendra added the pr-linter/exempt-readme The PR linter will not require README changes label Jun 11, 2024

TheRealAmazonKendra changed the title ~~feat(opensearch): adds OpenSearch 2.13 engine version~~ feat(opensearch): add OpenSearch 2.13 engine version Jun 11, 2024

TheRealAmazonKendra approved these changes Jun 11, 2024

View reviewed changes

Merge branch 'main' into feat/os-2.13

14a1364

mergify bot merged commit db3e77d into aws:main Jun 11, 2024
9 checks passed

timbru31 deleted the feat/os-2.13 branch June 12, 2024 08:08

jwoehrle mentioned this pull request Jun 12, 2024

chore: add OpenSearch version 2.13 #30521

Closed

1 task

This was referenced Jul 5, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#107

Open

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#108

Open

This was referenced Jul 16, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#109

Open

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#110

Open

NOUIY mentioned this pull request Jul 23, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#111

Open

aws locked as resolved and limited conversation to collaborators Jul 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(opensearch): add OpenSearch 2.13 engine version #30399

feat(opensearch): add OpenSearch 2.13 engine version #30399

timbru31 commented May 31, 2024

aws-cdk-automation left a comment

timbru31 commented May 31, 2024

cowsandmilk Jun 5, 2024

timbru31 Jun 10, 2024

TheRealAmazonKendra commented Jun 5, 2024

TheRealAmazonKendra commented Jun 5, 2024

TheRealAmazonKendra left a comment

timbru31 commented Jun 10, 2024 •

edited

Loading

TheRealAmazonKendra commented Jun 11, 2024 •

edited

Loading

mergify bot commented Jun 11, 2024

aws-cdk-automation commented Jun 11, 2024

mergify bot commented Jun 11, 2024

aws-cdk-automation commented Jul 25, 2024

feat(opensearch): add OpenSearch 2.13 engine version #30399

feat(opensearch): add OpenSearch 2.13 engine version #30399

Conversation

timbru31 commented May 31, 2024

Reason for this change

Description of changes

Description of how you validated changes

Checklist

aws-cdk-automation left a comment

Choose a reason for hiding this comment

timbru31 commented May 31, 2024

cowsandmilk Jun 5, 2024

Choose a reason for hiding this comment

timbru31 Jun 10, 2024

Choose a reason for hiding this comment

TheRealAmazonKendra commented Jun 5, 2024

TheRealAmazonKendra commented Jun 5, 2024

TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

timbru31 commented Jun 10, 2024 • edited Loading

TheRealAmazonKendra commented Jun 11, 2024 • edited Loading

mergify bot commented Jun 11, 2024

aws-cdk-automation commented Jun 11, 2024

AWS CodeBuild CI Report

mergify bot commented Jun 11, 2024

aws-cdk-automation commented Jul 25, 2024

timbru31 commented Jun 10, 2024 •

edited

Loading

TheRealAmazonKendra commented Jun 11, 2024 •

edited

Loading