Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(glue): support ConnectionType.MARKETPLACE and ConnectionType.CUSTOM #30395

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented May 31, 2024

Issue # (if applicable)

N/A

Reason for this change

MARKETPLACE and CUSTOM are not supported in the current L2 Construct. (SFTP is also missing, but it is not supported at the moment.)

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-glue-connection-connectioninput.html#cfn-glue-connection-connectioninput-connectiontype

Description of changes

Add missing connection types.

Description of how you validated changes

I determined that no testing was needed since this was only an addition of connection types.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the admired-contributor [Pilot] contributed between 13-24 PRs to the CDK label May 31, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team May 31, 2024 00:40
@github-actions github-actions bot added the p2 label May 31, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 31, 2024
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍
Could you also add a link to CFN documentation to the documentation of the ConnectionType class for context?

 * If you need to use a connection type that doesn't exist as a static member, you
 * can instantiate a `ConnectionType` object, e.g: `new ConnectionType('NEW_TYPE')`.
 * 
 * @see https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-glue-connection-connectioninput.html#cfn-glue-connection-connectioninput-connectiontype
 */
export class ConnectionType {

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels May 31, 2024
@mazyu36
Copy link
Contributor Author

mazyu36 commented Jun 1, 2024

@lpizzinidev
Thank you for your review!
I added the link.

@xazhao xazhao self-assigned this Jun 4, 2024
@TheRealAmazonKendra
Copy link
Contributor

We have a team doing a refactor of this module so we will need them to review this to ensure it doesn't cause conflicts there. Adding a do-not-merge label in the meantime.

@TheRealAmazonKendra TheRealAmazonKendra added the pr/do-not-merge This PR should not be merged at this time. label Jun 5, 2024
@xazhao xazhao removed their assignment Jul 29, 2024
@natalie-white-aws
Copy link

Refactor PR linked here: #30833

@kaizencc kaizencc changed the title chore(glue): add missing ConnectionType for the Connection class chore(glue): ConnectionType.MARKETPLACE and ConnectionType.CUSTOM Sep 9, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 9, 2024
@mazyu36 mazyu36 changed the title chore(glue): ConnectionType.MARKETPLACE and ConnectionType.CUSTOM chore(glue): support ConnectionType.MARKETPLACE and ConnectionType.CUSTOM Sep 9, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 9, 2024 14:05

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 9, 2024
@GavinZZ
Copy link
Contributor

GavinZZ commented Oct 10, 2024

@TheRealAmazonKendra FYI I'm removing the do-not-merge label as I cross compared with the glue refactor PR and it would not cause any conflicts. While we wait for the refactor PR, it's good to merge this in to support these two new types.

@GavinZZ GavinZZ removed the pr/do-not-merge This PR should not be merged at this time. label Oct 10, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 10, 2024
Copy link
Contributor

mergify bot commented Oct 10, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ab39cdb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f48220f into aws:main Oct 10, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Oct 10, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2024
@mazyu36 mazyu36 deleted the glue-connection-missing-type branch October 10, 2024 22:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants