Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(s3): allow user to set Log Group on S3 Bucket autoDeleteObjects provider lambda #30394

Merged
merged 13 commits into from
Jun 17, 2024
Merged

feat(s3): allow user to set Log Group on S3 Bucket autoDeleteObjects provider lambda #30394

merged 13 commits into from
Jun 17, 2024

Commits on Jun 12, 2024

  1. Create 'configureLambdaLogGroup' method in CustomResourceProviderBase… 

    … to set LoggingConfig for the underlying lambda
    @samson-keung
    samson-keung committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    c0b10d7 View commit details
    Browse the repository at this point in the history

  2. Update provider code gen logic to create pure getProvider() method

    @samson-keung
    samson-keung committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    3859bb1 View commit details
    Browse the repository at this point in the history

  3. Create new static method setAutoDeleteObjectsLogGroup in Bucket const… 

    …ruct
    @samson-keung
    samson-keung committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    f5dcbe7 View commit details
    Browse the repository at this point in the history

  4. Update integ.bucket-auto-delete-objects to cover the new setAutoDelet… 

    …eObjectsLogGroup method
    @samson-keung
    samson-keung committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    3b2ef56 View commit details
    Browse the repository at this point in the history

  5. Update S3 README

    @samson-keung
    samson-keung committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    91c4710 View commit details
    Browse the repository at this point in the history

  6. Update provider code gen logic to create useLogGroup() method

    @samson-keung
    samson-keung committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    21c771d View commit details
    Browse the repository at this point in the history

  7. allow setAutoDeleteObjectsLogGroup to be called before bucket creation

    @samson-keung
    samson-keung committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    fba53e8 View commit details
    Browse the repository at this point in the history

  8. update setAutoDeleteObjectsLogGroup to take a Stack instead of a Cons… 

    …truct scope
    @samson-keung
    samson-keung committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    cebc4f3 View commit details
    Browse the repository at this point in the history

  9. resolve conflicts

    @samson-keung
    samson-keung committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    90520ad View commit details
    Browse the repository at this point in the history

  10. update unit test with latest changes from main

    @samson-keung
    samson-keung committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    3b7e4de View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. revert unintended change in cx-api

    @samson-keung
    samson-keung committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    ca1acbe View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. update doc

    @samson-keung
    samson-keung committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    5d12bf3 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Merge branch 'main' into bucket-auto-delete-objects-logging

    @GavinZZ
    GavinZZ authored Jun 17, 2024
    Configuration menu
    Copy the full SHA
    fbde1ad View commit details
    Browse the repository at this point in the history