Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): v2.143.1 #30377

Merged
merged 2 commits into from
May 30, 2024
Merged

chore(release): v2.143.1 #30377

merged 2 commits into from
May 30, 2024

Conversation

shikha372
Copy link
Contributor

@shikha372 shikha372 commented May 30, 2024 •
edited
Loading

See CHANGELOG

@shikha372
revert: "fix(ses-actions): permissions too wide for S3 action" (#30375)
6c716c6 
### Issue # (if applicable)

Closes #[30143](#30143).

### Reason for this change

Fix the below deployment failure
Deployment fails with a Could not write to bucket error:

1:36:13 PM | CREATE_FAILED | AWS::SES::ReceiptRule | TestRuleSetStoreToBucketRule3E41D5CF
Could not write to bucket: reprosess3rulestack-testemailstoref58b593c-dxh45g1m3y6b (Service: AmazonSimpleEmailService; Status Code: 400; Error Code: InvalidS3Configuration; Request ID: 817f5520-748b-4bae-b347-ec68df52b675; Proxy: null)


This PR reverts the changes introduced in 
PR #29833


### Description of changes

This PR reverts the change that was made in CDK v2.139.0 to reduce overly broad permissions allocated to SES for the S3 receipt rule action. This resulted in deployment failure where SES is unable to write to s3 bucket.


### Description of how you validated changes

Dry-run for integration tests 

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation aws-cdk-automation requested a review from a team May 30, 2024 00:21
@github-actions github-actions bot added the p2 label May 30, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 30, 2024
@shikha372 shikha372 added the pr/no-squash This PR should be merged instead of squash-merging it label May 30, 2024
moelasmar
moelasmar reviewed May 30, 2024
View reviewed changes
CHANGELOG.v2.alpha.md Outdated Show resolved Hide resolved
moelasmar
moelasmar reviewed May 30, 2024
View reviewed changes
CHANGELOG.v2.md Outdated Show resolved Hide resolved
moelasmar
moelasmar reviewed May 30, 2024
View reviewed changes
CHANGELOG.v2.md Outdated Show resolved Hide resolved
moelasmar
moelasmar reviewed May 30, 2024
View reviewed changes
Copy link
Contributor

@moelasmar moelasmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some minor comments

shikha372
shikha372 commented May 30, 2024
View reviewed changes
Copy link
Contributor Author

@shikha372 shikha372 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing changelog

CHANGELOG.v2.alpha.md Outdated Show resolved Hide resolved
CHANGELOG.v2.md Outdated Show resolved Hide resolved
CHANGELOG.v2.md Outdated Show resolved Hide resolved
@shikha372 shikha372 marked this pull request as ready for review May 30, 2024 00:34
@shikha372 shikha372 mentioned this pull request May 30, 2024
Closed
scanlonp
scanlonp requested changes May 30, 2024
View reviewed changes
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These commits are not squashed. Please consolidate the changelog edits into 1 chore commit.

@shikha372 shikha372 added pr/no-squash This PR should be merged instead of squash-merging it and removed pr/no-squash This PR should be merged instead of squash-merging it labels May 30, 2024
scanlonp
scanlonp approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: eb451cb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented May 30, 2024

Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 29b0d66 into v2-release May 30, 2024
13 checks passed
@mergify mergify bot deleted the patch/v2.143.1 branch May 30, 2024 01:18
This was referenced Jun 1, 2024
Closed
Closed
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moelasmar moelasmar moelasmar approved these changes

@scanlonp scanlonp scanlonp approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2 pr/no-squash This PR should be merged instead of squash-merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shikha372 @aws-cdk-automation @scanlonp @moelasmar