Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rds): add SQL Server versions 16.00.4115.5.v1 and 16.00.4120.1.v1 #30267

Closed
wants to merge 3 commits into from
Closed

chore(rds): add SQL Server versions 16.00.4115.5.v1 and 16.00.4120.1.v1 #30267

wants to merge 3 commits into from

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented May 18, 2024

Add missing SQL Server versions.

aws rds describe-db-engine-versions --engine sqlserver-ex --query 'DBEngineVersions[].EngineVersion'
[
    // omit
    "16.00.4115.5.v1",
    "16.00.4120.1.v1"
]

https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/CHAP_SQLServer.html#SQLServer.Concepts.General.VersionSupport

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label May 18, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team May 18, 2024 11:16
@github-actions github-actions bot added the valued-contributor [Pilot] contributed between 6-12 PRs to the CDK label May 18, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 18, 2024
@github-actions github-actions bot mentioned this pull request May 20, 2024
Closed
@nmussy
Copy link
Contributor

nmussy commented May 21, 2024

15.00.4365.2.v1 is also missing from SqlServerEngineVersion, see #30282 (comment) for more information

@mazyu36
Copy link
Contributor Author

mazyu36 commented May 22, 2024

@nmussy
Thank you for the information !
I added the missing one of sql server engine version.

@github-actions github-actions bot mentioned this pull request Jun 1, 2024
Closed
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: cc6eb5c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mazyu36
Copy link
Contributor Author

mazyu36 commented Jun 26, 2024

Closed due to duplication with #30305.

@mazyu36 mazyu36 closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mazyu36 @nmussy @aws-cdk-automation