-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): support Stage properties in App constructor #30050
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Clarification Request I didn't find any integration tests validating behaviour of |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Issue #24570
Closes #24570.
Reason for this change
App
construct inherits fromStage
but does not allow to passStage
parameters to constructor.Description of changes
Two parameters
env
andpermissionsBoundary
are added toAppProps
.stageName
is now only unsupported parameter. That is becauseApp
is special case ofStage
acting as root for construct tree and as such it is synthesised to root of output directory.Description of how you validated changes
I copied unit tests for
env
propagation fromStage
toApp
.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license