Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): support Stage properties in App constructor #30050

Closed
wants to merge 3 commits into from
Closed

feat(core): support Stage properties in App constructor #30050

wants to merge 3 commits into from

Conversation

soucema9
Copy link
Contributor

@soucema9 soucema9 commented May 3, 2024

Issue #24570

Closes #24570.

Reason for this change

App construct inherits from Stage but does not allow to pass Stage parameters to constructor.

Description of changes

Two parameters env and permissionsBoundary are added to AppProps.

stageName is now only unsupported parameter. That is because App is special case of Stage acting as root for construct tree and as such it is synthesised to root of output directory.

Description of how you validated changes

I copied unit tests for env propagation from Stage to App.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels May 3, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team May 3, 2024 11:04
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@soucema9 soucema9 changed the title feat(core): Support Stage prperties in App constructor feat(core): support Stage properties in App constructor May 3, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 11a9821
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@soucema9
Copy link
Contributor Author

soucema9 commented May 9, 2024

Clarification Request

I didn't find any integration tests validating behaviour of App or Stage. And I'm not sure if it's even possible or make sense to write integration tests for this PR. As integration tests usually create stack, deploy it and assert on deployed resources but changes in this PR will affect where the stack is deployed.

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Jun 1, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-cdk-lib(core): App Inherits From Stage, But Doesn't Allow Setting Region
2 participants