Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ecr-assets): fixes documentation for cross-account access to dockerImageAsset ECR repository #29766

Merged
merged 3 commits into from
Apr 8, 2024
Merged

docs(ecr-assets): fixes documentation for cross-account access to dockerImageAsset ECR repository #29766

merged 3 commits into from
Apr 8, 2024

Commits on Apr 8, 2024

  1. Improves documentation for issue in aws#13327 

    In cdkv2, it is no longer possible to add permissions on the repository for `dockerImageAsset`, but the docs were not updated.

Updates documentation for aws-ecr-assets. Mentions that it is no longer possible to grant repository permissions on `dockerImageAsset` for cross-account access and provides possible alternate routes.

Rebuilt doc change.

- [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    @nickgardner-amazon
    nickgardner-amazon committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    04fd2f9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-ecr-assets-docs

    @nickgardner-amazon
    nickgardner-amazon authored Apr 8, 2024
    Configuration menu
    Copy the full SHA
    87574b2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix-ecr-assets-docs

    @mergify
    mergify[bot] authored Apr 8, 2024
    Configuration menu
    Copy the full SHA
    d9c4d2b View commit details
    Browse the repository at this point in the history