Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sns): kms key is not deleted in integ.sns.ts #29664

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

jun1-t
Copy link
Contributor

@jun1-t jun1-t commented Mar 31, 2024

Issue # (if applicable)

Closes #29663

Reason for this change

kms key created within integ test remains after integ test.

Description of changes

Added "pendingWindow" and "removalPolicy" to kms resource.

    const key = new Key(this, 'CustomKey', {
      pendingWindow: Duration.days(7),
      removalPolicy: RemovalPolicy.DESTROY,
    });

Description of how you validated changes

I confirmed with integ test that it works as expected.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Mar 31, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 31, 2024 15:38
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@jun1-t jun1-t changed the title fix(sns): KMS key is not deleted in integ.sns.ts fix(sns): kms key is not deleted in integ.sns.ts Mar 31, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 31, 2024 15:41

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 31, 2024
@msambol
Copy link
Contributor

msambol commented Apr 1, 2024

@jun1-t Could you change this to a chore ? otherwise looks good.

@xazhao xazhao changed the title fix(sns): kms key is not deleted in integ.sns.ts chore(sns): kms key is not deleted in integ.sns.ts Apr 1, 2024
@github-actions github-actions bot added the effort/small Small work item – less than a day of effort label Apr 1, 2024
xazhao
xazhao previously approved these changes Apr 1, 2024
Copy link
Contributor

@xazhao xazhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for finding the issue.

Copy link
Contributor

mergify bot commented Apr 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 1, 2024
Copy link
Contributor

mergify bot commented Apr 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed xazhao’s stale review April 1, 2024 19:11

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 650d73a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 1, 2024
Copy link
Contributor

mergify bot commented Apr 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 49ae449 into aws:main Apr 1, 2024
14 checks passed
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 1, 2024
@jun1-t
Copy link
Contributor Author

jun1-t commented Apr 3, 2024

@msambol Thanks. I understand. I'll use chore in situations like this.

@xazhao Thanks for editing and approval.

@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-sns: KMS key is not deleted in integ.sns.ts
4 participants