-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stepfunctions-tasks): allow BedrockInvokeModel
to use JsonPath to specify input/output S3 URIs.
#29647
Conversation
… specify input/output S3 URIs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
BedrockInvokeModel
to use JsonPath to specify input/output S3 URIs.
I am currently waiting for this change to be released. It is blocking my development. By when i can expect this change to be released |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Issue # (if applicable)
Closes #29229
Reason for this change
when trying to use JsonPath to specify the S3 URIs that BedrockInvokeModel will read from and write from, you get an error.
Example of the Error message:
jsii.errors.JavaScriptError: Error: Field references must be the entire string, cannot concatenate them (found 's3://${Token[prompt_bucket.348]}/${Token[prompt_key.349]}')
Description of changes
We extended the implementation in
BedrockInvokeModel
to allow for the use of an optional JsonPath for S3 URIs. This allows directly using S3 URIs if provided through a news3Uri
field inBedrockInvokeModelInputProps
andBedrockInvokeModelOutputProps
.Description of how you validated changes
New unit tests and integration tests for the new code.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license