Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepfunctions-tasks): allow BedrockInvokeModel to use JsonPath to specify input/output S3 URIs. #29647

Closed
wants to merge 2 commits into from

Conversation

ganialhamad
Copy link

@ganialhamad ganialhamad commented Mar 29, 2024

Issue # (if applicable)

Closes #29229

Reason for this change

when trying to use JsonPath to specify the S3 URIs that BedrockInvokeModel will read from and write from, you get an error.

Example of the Error message:
jsii.errors.JavaScriptError: Error: Field references must be the entire string, cannot concatenate them (found 's3://${Token[prompt_bucket.348]}/${Token[prompt_key.349]}')

Description of changes

We extended the implementation in BedrockInvokeModel to allow for the use of an optional JsonPath for S3 URIs. This allows directly using S3 URIs if provided through a new s3Uri field in BedrockInvokeModelInputProps and BedrockInvokeModelOutputProps.

Description of how you validated changes

New unit tests and integration tests for the new code.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Mar 29, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 29, 2024 06:48
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 labels Mar 29, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@ganialhamad ganialhamad changed the title fix(stepfunctions-tasks): Allow BedrockInvokeModel to use JsonPath to specify input/output S3 URIs. fix(stepfunctions-tasks): allow BedrockInvokeModel to use JsonPath to specify input/output S3 URIs. Mar 29, 2024
@ganialhamad ganialhamad marked this pull request as draft March 29, 2024 07:41
@srinivas17042001
Copy link

I am currently waiting for this change to be released. It is blocking my development. By when i can expect this change to be released

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@ganialhamad ganialhamad marked this pull request as ready for review April 21, 2024 09:01
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5d49a31
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Apr 27, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(stepfunctions-tasks): BedrockInvokeModel cannot use JsonPath to specify input/output S3 URIs
3 participants