-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ecs): stop using deprecated methods and remove them #2947
Conversation
The deprecated methods are: `placeOnMemberOf()`, `placeSpreadAcross()`, `placePackedBy()`, `placeRandomly()`. This closes #2946.
@rix0rrr I think
|
c5e43e2#diff-7a15a977f3f5e042a3d8db8f32830fb3 is the last working commit where |
@pkandasamy91 |
After consulting Parideep, I realized that when the CDK core is changed, running ../../../script/buildup is insufficient. Need to rebuild the core first by running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deprecated methods are:
placeOnMemberOf()
,placeSpreadAcross()
,placePackedBy()
,placeRandomly()
.Closes #2946.
Pull Request Checklist
design
folderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.