Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bedrock): update foundation models #29468

Merged
merged 3 commits into from
Mar 23, 2024
Merged

Conversation

nmussy
Copy link
Contributor

@nmussy nmussy commented Mar 13, 2024

Issue # (if applicable)

Could not find any in the backlog

Reason for this change

Update the CDK listed Bedrock foundation models to match the current availability, as well as add missing deprecated versions

Description of changes

  • Added new models
  • Marked existing models as deprecated

Description of how you validated changes

I compared the current CDK models to live SDK data, using the bedrock:ListFoundationModels API results. Deprecated versions were established using the modelLifecycle.status field

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Mar 13, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 13, 2024 12:29
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Mar 13, 2024
@nmussy
Copy link
Contributor Author

nmussy commented Mar 13, 2024

Feel free to leave feedback about the ordering of the models, I tried to group them by provider/"kind"/version

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 13, 2024
Copy link
Contributor

@msambol msambol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I confirmed the ones in red are being moved to another place in the list.

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Mar 18, 2024
@shikha372 shikha372 self-assigned this Mar 18, 2024
Copy link
Contributor

mergify bot commented Mar 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 18, 2024
Copy link
Contributor

mergify bot commented Mar 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@shikha372
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Mar 22, 2024

update

✅ Branch has been successfully updated

Copy link
Contributor

mergify bot commented Mar 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3def977
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 1c527a3 into aws:main Mar 23, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Mar 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

jun1-t pushed a commit to jun1-t/aws-cdk that referenced this pull request Mar 23, 2024
### Issue # (if applicable)

Could not find any in the backlog

### Reason for this change

Update the CDK listed Bedrock foundation models to match the current availability, as well as add missing deprecated versions

### Description of changes

* Added new models
* Marked existing models as deprecated

### Description of how you validated changes

I compared the current CDK models to live SDK data, using the `bedrock:ListFoundationModels` API results. Deprecated versions were established using the `modelLifecycle.status` field

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@nmussy nmussy deleted the chore-bedrock-models branch March 23, 2024 14:40
ahammond pushed a commit to ahammond/aws-cdk that referenced this pull request Mar 26, 2024
### Issue # (if applicable)

Could not find any in the backlog

### Reason for this change

Update the CDK listed Bedrock foundation models to match the current availability, as well as add missing deprecated versions

### Description of changes

* Added new models
* Marked existing models as deprecated

### Description of how you validated changes

I compared the current CDK models to live SDK data, using the `bedrock:ListFoundationModels` API results. Deprecated versions were established using the `modelLifecycle.status` field

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants