Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apprunner): auto deployment not triggered due to insufficient permission #29426

Closed
wants to merge 2 commits into from

Conversation

pinelibg
Copy link

@pinelibg pinelibg commented Mar 10, 2024

Issue # (if applicable)

Closes #26640.

Reason for this change

Auto deployment of an AppRunner service is not triggered even when the autoDeploymentsEnabled props is set to true.

This is because the access role lacks the necessary ecr:DescribeImages permission required by AppRunner.

Description of changes

The grantPull method grants permissions for pulling images to the access role. However, it does not include the ecr:DescribeImages permission required by AppRunner.

this.source.ecrRepository.grantPull(this.accessRole);

Required policy of the AppRunner is documented in the doc (https://docs.aws.amazon.com/apprunner/latest/dg/security_iam_service-with-iam.html#security_iam_service-with-iam-rolesAWSAppRunnerServicePolicyForECRAccess).

So it adds ecr:DescribeImages permission to the role after the grantPull call.

Another fix for the same issue #29285 grants broader permission by allowing some actions for all resources (*) instead of just the source ECR repository.
This PR grants minimal required permissions.

Description of how you validated changes

  • Updated the integration test snapshot and checked the IAM policy changes for the access role to include the appended ecr:DescribeImages permission for the ECR repository.
  • There is no unit test for IAM policy for the access role currently, so I haven't modified or created any unit test.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Mar 10, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 10, 2024 14:27
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@pinelibg
Copy link
Author

pinelibg commented Mar 10, 2024

Exemption Request
I have validated the IAM policy changes on the access role by running integration test and checking the snapshot diff.
(5c93a0a#diff-e995c5eaacbb2bc5bcf2c9266d1067f5a514af924698b0c28e36e81e13a712a8R51)

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Mar 10, 2024
@pinelibg pinelibg force-pushed the fix-apprunner-autodeployment branch from a016af0 to 31cb8f8 Compare March 17, 2024 14:43
@pinelibg pinelibg force-pushed the fix-apprunner-autodeployment branch 2 times, most recently from 2873ae0 to 0b79fea Compare March 29, 2024 02:35
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@pinelibg
Copy link
Author

pinelibg commented Apr 4, 2024

(Re) Exemption Request
Since there are no unit tests in this repository that would validate the permissions of the IAM roles, I don't think that unit test is required for this change.

@pinelibg pinelibg force-pushed the fix-apprunner-autodeployment branch from 56daf60 to 1687ee1 Compare April 5, 2024 01:17
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1687ee1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@paulhcsun paulhcsun added the pr-linter/exempt-test The PR linter will not require test changes label Apr 8, 2024
@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Apr 9, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exempt-test The PR linter will not require test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apprunner: After pushing a Docker image to ECR, isn't triggered.
3 participants