-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(apprunner): auto deployment not triggered due to insufficient permission #29426
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request |
a016af0
to
31cb8f8
Compare
2873ae0
to
0b79fea
Compare
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
(Re) Exemption Request |
56daf60
to
1687ee1
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
Issue # (if applicable)
Closes #26640.
Reason for this change
Auto deployment of an AppRunner service is not triggered even when the
autoDeploymentsEnabled
props is set to true.This is because the access role lacks the necessary
ecr:DescribeImages
permission required by AppRunner.Description of changes
The
grantPull
method grants permissions for pulling images to the access role. However, it does not include theecr:DescribeImages
permission required by AppRunner.aws-cdk/packages/@aws-cdk/aws-apprunner-alpha/lib/service.ts
Line 1255 in 730fe63
Required policy of the AppRunner is documented in the doc (https://docs.aws.amazon.com/apprunner/latest/dg/security_iam_service-with-iam.html#security_iam_service-with-iam-roles →
AWSAppRunnerServicePolicyForECRAccess
).So it adds
ecr:DescribeImages
permission to the role after thegrantPull
call.Another fix for the same issue #29285 grants broader permission by allowing some actions for all resources (
*
) instead of just the source ECR repository.This PR grants minimal required permissions.
Description of how you validated changes
ecr:DescribeImages
permission for the ECR repository.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license