-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): rename @aws-cdk/cdk to @aws-cdk/core #2932
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
requested review from
RomainMuller,
skinny85,
SoManyHs and
a team
as code owners
June 19, 2019 16:27
eladb
force-pushed
the
benisrae/rename-core
branch
from
June 19, 2019 17:34
adbdb18
to
8e775ef
Compare
rix0rrr
approved these changes
Jun 20, 2019
eladb
force-pushed
the
benisrae/rename-core
branch
from
June 23, 2019 20:38
8e775ef
to
beab712
Compare
This was referenced Aug 22, 2019
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
This was referenced Dec 12, 2019
This was referenced Dec 13, 2019
This was referenced Jan 20, 2020
This was referenced Sep 24, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the module @aws-cdk/cdk to @aws-cdk/core since this is a more suitable name for it.
Language-specific names:
core
but package and groupId are stillsoftware.amazon.awscdk
This change completely deletes the @aws-cdk/cdk module from the repo as a temporary measure, to ensure there are no lingering references. A subsequent commit will introduce @aws-cdk/cdk as a deprecated package.
Fixed #2733
BREAKING CHANGE: The
@aws-cdk/cdk
module was renamed to @aws-cdk/coreaws_cdk.cdk
module was renamed toaws_cdk.core
cdk
in groupIdsoftware.amazon.awscdk
was renamed tocore
TODO:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.