-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@aws-cdk/aws-elasticloadbalancingv2)/logAccessLogs provides open permissions on log bucket for alb #2929
Merged
rix0rrr
merged 4 commits into
aws:master
from
made2591:fix/application-load-balancer-log
Jun 21, 2019
Merged
fix(@aws-cdk/aws-elasticloadbalancingv2)/logAccessLogs provides open permissions on log bucket for alb #2929
rix0rrr
merged 4 commits into
aws:master
from
made2591:fix/application-load-balancer-log
Jun 21, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
made2591
changed the title
fix(@aws-cdk/aws-elasticloadbalancingv2)/logAccessLogs provide open permissions on log bucket for alb
fix(@aws-cdk/aws-elasticloadbalancingv2)/logAccessLogs provides open permissions on log bucket for alb
Jun 19, 2019
rix0rrr
reviewed
Jun 19, 2019
packages/@aws-cdk/aws-elasticloadbalancingv2/lib/alb/application-load-balancer.ts
Outdated
Show resolved
Hide resolved
rix0rrr
approved these changes
Jun 20, 2019
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
This was referenced Sep 24, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
The policy generated by the LogAccessLogs method allows too wide of a permission on a prefix of loadbalancer
vs
To Reproduce
Create a ALB and call LogAccessLogs on it, with a bucket generates a bucket policy with
${log-bucket.Arn}/loadbalancer*
.Expected behavior
Fixed with correct permission as suggested in doc.
close #2824
Pull Request Checklist
design
folderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.