feat(cli): support CloudFormation simplified resource import

[tmokmss]

Issue # (if applicable)

Closes #28060.

Reason for this change

This feature allows to automatically import exsting resources with the same physical name, such as S3 bucket, DDB table, etc, during a CFn deployment.

Because resource import is a vital feature for CDK users e.g. to refactor a construct tree, cdk migrate, etc, it would benefit many potential users if cdk natively support it.

Description of changes

This PR adds a CLI option --import-exsting-resources: boolean to cdk deploy command and pass it to createChangeSet API call.

Description of how you validated changes

Added a cli integ test.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Pull request has been modified.

[tmokmss]

@HBobertz @comcalvi

Thanks! I addressed all the comments from you :)

It's unclear if this flag works with IMPORT type changesets. Those changesets should not create anything, but autoimport likely needs a CREATE to import the resource...maybe IMPORT changesets recognize that?

As far as I tested, CFn decides whether a resource is created or imported when we create a changeset. If a resource will be imported, the changeset type for the resource will become IMPORT, and if not, it wil become CREATE.

[comcalvi]

LGTM, pending a CLI test run.

[tmokmss]

@comcalvi Thanks! Just for confirmation, have you triggered a cli test? I see the request is still pending. (not really sure how it works though)

[tmokmss]

@comcalvi Hi, let me know the integ-test result when you get a chance :) I guess I don't have access to it.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 5b1db10
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[aws-cdk-automation]

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

[kaizencc]

@tmokmss I mean to help you get this PR across the finish line. first step was to fix the merge conflicts, which are a little bit difficult. I did it locally, but I'm not able to push to this branch. Is there any reason that is the case on your end? It makes me sad because I spent some time trying to fix up the branch for you :(.

error: Authentication error: Authentication required: You must have push access to verify locks
error: failed to push some refs to 'https://github.com/tmokmss/aws-cdk.git'

i can also start a new branch and we can go from there but im first wondering if there's something quick you can do on your end to ensure that i have push access to your fork.

[tmokmss]

Hi @kaizencc, thanks for working on this and sorry I didn't realize it was in conflict.

I confirmed that `Allow edits and access to secrets by maintainers' is checked, so I think you should be able to push commits. Not sure about the error, but if this is a blocker, it's okay to create a new branch and PR. I'm excited to see this finally merged :)

[kaizencc]

@tmokmss i can't figure it out :/ so i just went ahead and created a new PR to main from your PR. I think you'll still get credit, but i also want to add a coauthor message to the PR description just in case. I'll need an email address associated to your github account to make that happen though.

[tmokmss]

@kaizencc thanks for your kindness! You can use this address:
[email protected]

[kaizencc]

#32676 was merged

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.