Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eks): add AlbControllerVersion v2.5.2 - v2.5.4 and v2.6.0 - v2.6.2 #27910

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

go-to-k
Copy link
Contributor

@go-to-k go-to-k commented Nov 9, 2023

This PR adds AlbControllerVersion v2.5.2 - v2.5.4, and v2.6.0 - v2.6.2.

See the aws-load-balancer-controller releases.

Each version to correspond to eks-chart versions is based on aws-load-balancer-controller/Chart.yaml history.

For example, v2.6.2 for AlbControllerVersion is to v1.6.2 for charts.

https://github.com/aws/eks-charts/blob/a644fd925ca091d881b3a42aace268322f484455/stable/aws-load-balancer-controller/Chart.yaml

apiVersion: v2
name: aws-load-balancer-controller
description: AWS Load Balancer Controller Helm chart for Kubernetes
version: 1.6.2
appVersion: v2.6.2

Closes #27890.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the star-contributor [Pilot] contributed between 25-49 PRs to the CDK label Nov 9, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team November 9, 2023 16:02
@github-actions github-actions bot added p2 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. labels Nov 9, 2023
@go-to-k go-to-k changed the title feat(eks): update AlbControllerVersion feat(eks): update AlbControllerVersion v2.5.2 - v2.5.4 and v2.6.0 - v2.6.2 Nov 9, 2023
@go-to-k go-to-k marked this pull request as ready for review November 9, 2023 16:10
@go-to-k go-to-k changed the title feat(eks): update AlbControllerVersion v2.5.2 - v2.5.4 and v2.6.0 - v2.6.2 feat(eks): add AlbControllerVersion v2.5.2 - v2.5.4 and v2.6.0 - v2.6.2 Nov 9, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 9, 2023
scanlonp
scanlonp previously approved these changes Nov 10, 2023
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition, good tests, good docs. The history shows why app version and version are not on the same track for the v2.5.x versions.

The Kubernetes version increase is necessary as versions past 2.5.0 require Kubernetes 1.22+.

@mergify mergify bot dismissed scanlonp’s stale review November 10, 2023 02:02

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 10, 2023
Copy link
Contributor

mergify bot commented Nov 10, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 770da60
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d33651f into aws:main Nov 10, 2023
9 checks passed
Copy link
Contributor

mergify bot commented Nov 10, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@go-to-k go-to-k deleted the feat/eks-alb-AlbControllerVersion branch November 10, 2023 03:25
mikewrighton pushed a commit that referenced this pull request Nov 13, 2023
….2 (#27910)

This PR adds AlbControllerVersion v2.5.2 - v2.5.4, and v2.6.0 - v2.6.2.

See the [aws-load-balancer-controller releases](https://github.com/kubernetes-sigs/aws-load-balancer-controller/releases).

Each version to correspond to eks-chart versions is based on [aws-load-balancer-controller/Chart.yaml history](https://github.com/aws/eks-charts/commits/master/stable/aws-load-balancer-controller/Chart.yaml).

For example, v2.6.2 for AlbControllerVersion is to v1.6.2 for charts.

https://github.com/aws/eks-charts/blob/a644fd925ca091d881b3a42aace268322f484455/stable/aws-load-balancer-controller/Chart.yaml

```yaml
apiVersion: v2
name: aws-load-balancer-controller
description: AWS Load Balancer Controller Helm chart for Kubernetes
version: 1.6.2
appVersion: v2.6.2
```

Closes #27890.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_eks: update AlbControllerVersion
3 participants