Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Correct buildspec so it does not fail #2737

Merged
merged 1 commit into from
Jun 4, 2019
Merged

fix(build): Correct buildspec so it does not fail #2737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion buildspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,12 @@ phases:
- /bin/bash ./build.sh
post_build:
commands:
- "[ -f .BUILD_COMPLETED ] && [ -z \"${SKIP_PACK:-}\" ] && /bin/bash ./pack.sh"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not follow @rix0rrr's suggestion and implement this inside pack.sh itself? Much safer and you can even test it before merging...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels wrong to me that calling pack.sh would not... pack... if some environment variable is set. I rather NOT call pack.sh in that case.

- |
if [ -f .BUILD_COMPLETED ]; then
if [ -z \"${SKIP_PACK:-}\" ]; then
/bin/bash ./pack.sh
fi
fi
artifacts:
files:
- "**/*"
Expand Down