Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cx-api): improve compatibility messages for cli <=> app #2676

Merged
merged 3 commits into from
May 30, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update cloud-assembly.ts
Elad Ben-Israel authored May 29, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 6084e6c9ea7350227ecaf798de20c1d3cef3c27f
4 changes: 2 additions & 2 deletions packages/@aws-cdk/cx-api/lib/cloud-assembly.ts
Original file line number Diff line number Diff line change
@@ -117,7 +117,7 @@ export class CloudAssemblyBuilder {

// we leverage the fact that outdir is long-lived to avoid staging assets into it
// that were already staged (copying can be expensive). this is achieved by the fact
// that assets use a source hash as their name. other artifacts, and the manifest,
// that assets use a source hash as their name. other artifacts, and the manifest itself,
// will overwrite existing files as needed.

if (fs.existsSync(this.outdir)) {
@@ -206,4 +206,4 @@ function filterUndefined(obj: any): any {

function ignore(_x: any) {
return;
}
}