fix(lambda): bundling fails with pnpm >= 8.4.0 (#26478) #26479
Conversation
Fixed location of -f flag in rm command for pnpm esbuild bundling step when removing node_modules/.modules.yaml from output dir. Signed-off-by: Damien Hill <[email protected]>
github-actions
bot
added
beginning-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
mrgrain
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Fix issue with order of `-f` flag and file path in `rm` command for `pnpm` esbuild bundling step to remove `node_modules/.modules.yaml` from output dir. This is continuing to cause bundling step to fail for `pnpm` >= 8.4.0 with no external `node_modules` specified per issue aws#26478. Solved by moving the `-f` flag before file path in the `rm` command and updating relevant unit test. Please note that I haven't adjusted the `del` command for windows env as not sure if same issue occurs in that env. Exemption Request: No changes to integration test output of `aws-lambda-nodejs/test/integ.dependencies-pnpm.js` and don't feel this warrants a separate integration test. Closes aws#26478. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Fix issue with order of
-fflag and file path inrmcommand forpnpmesbuild bundling step to removenode_modules/.modules.yamlfrom output dir. This is continuing to cause bundling step to fail forpnpm>= 8.4.0 with no externalnode_modulesspecified per issue #26478.Solved by moving the
-fflag before file path in thermcommand and updating relevant unit test. Please note that I haven't adjusted thedelcommand for windows env as not sure if same issue occurs in that env.Exemption Request: No changes to integration test output of
aws-lambda-nodejs/test/integ.dependencies-pnpm.jsand don't feel this warrants a separate integration test.Closes #26478.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license