-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lambda): update default node runtime for all partitions #26475
Conversation
…na, and Gov regions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Clarification Request. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
received a tip about a custom resource potentially not working with node18. so i'm gonna run it to check
Hmm I got this error on delete when running log-retention integ. Might not be ready for node18 yet but I haven't had time to dive in and figure out whats necessary to fix
|
I am surprised that this would still be necessary. I thought we just did a big campaign upgrading aws-sdkv2 -> v3 everywhere, which should have included this. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Node18 is the default runtime environment for lambdas in the default, China, and GovCloud regions.
This fix updates the runtime default versions for constructs that were still using older versions, in particular:
LogRetention
AwsCustomResource
CustomResourceProvider
Also, it updates the
DefaultCrNodeVersionMap
in the fact tables to reflect the updated values.Closes #26461.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license