Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-certificatemanager): allow users to specify region for DNS certificates #2626

Merged
merged 1 commit into from
May 28, 2019

Conversation

CaerusKaru
Copy link
Contributor

  • CloudFront requires certificates to be registered in the us-east-1 region, so
    this allows users to override the default, which places the certificates in
    whatever region the stack exists in

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@CaerusKaru CaerusKaru requested a review from a team as a code owner May 24, 2019 05:31
@rix0rrr
Copy link
Contributor

rix0rrr commented May 24, 2019

Happy to merge this, but currently the tests are failing.

@rix0rrr
Copy link
Contributor

rix0rrr commented May 24, 2019

I notice the Route53 record are not necessarily in the same region as the cert. I'm assuming that'll be fine?

@CaerusKaru
Copy link
Contributor Author

@rix0rrr Yeah, Route53 records are global. Will double-check on undefined region, but pretty sure it’s undefined by default.

@CaerusKaru
Copy link
Contributor Author

Updated the test file, so CI should pass this time, and confirmed that region is undefined by default.

…ertificates

* CloudFront requires certificates to be registered in the us-east-1 region, so
this allows users to override the default, which places the certificates in
whatever region the stack exists in
@CaerusKaru
Copy link
Contributor Author

@rix0rrr Travis now passing, I suspect CB will be soon behind 👍

@rix0rrr rix0rrr merged commit 1a7d4db into aws:master May 28, 2019
@CaerusKaru CaerusKaru deleted the adam/cert-region branch May 28, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants