-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-certificatemanager): allow users to specify region for DNS certificates #2626
Conversation
b39bb5d
to
c80d8e7
Compare
...ws-cdk/aws-certificatemanager/lambda-packages/dns_validated_certificate_handler/lib/index.js
Show resolved
Hide resolved
Happy to merge this, but currently the tests are failing. |
I notice the Route53 record are not necessarily in the same region as the cert. I'm assuming that'll be fine? |
@rix0rrr Yeah, Route53 records are global. Will double-check on undefined region, but pretty sure it’s undefined by default. |
c80d8e7
to
36d6fef
Compare
Updated the test file, so CI should pass this time, and confirmed that region is undefined by default. |
…ertificates * CloudFront requires certificates to be registered in the us-east-1 region, so this allows users to override the default, which places the certificates in whatever region the stack exists in
36d6fef
to
1c279e1
Compare
@rix0rrr Travis now passing, I suspect CB will be soon behind 👍 |
this allows users to override the default, which places the certificates in
whatever region the stack exists in
Pull Request Checklist
design
folderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.