chore(cdk): Change Docker base image to Amazon Linux #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clareliguori
commented
May 24, 2019
| @@ -25,8 +25,10 @@ for module in ${modules}; do | |||
| # Symlink executable scripts into place as well. This is not completely | |||
| # according to spec (we look in the bin/ directory instead of the { "scripts" | |||
| # } entry in package.json but it's quite a bit easier. | |||
| [[ -d $module/bin ]] && for script in $(find $module/bin -perm +111); do | |||
There was a problem hiding this comment.
Note on this change: This format causes ./link-all.sh to return with exit code 1, because the last module doesn't have a bin directory, which fails the Docker image build.
clareliguori
commented
May 24, 2019
| ln -fs ${script} node_modules/.bin | ||
| done | ||
| if [[ -d $module/bin ]]; then | ||
| for script in $(find $module/bin -perm /111); do |
There was a problem hiding this comment.
Note on this change (-perm +111 to -perm /111). The syntax -perm +omode was removed in findutils 4.5.12, in favour of -perm /omode. Ubuntu 18.04 has findutils 4.6.0. AL2 has findutils 4.5.11, which provides this warning:
The interpretation of -perm +omode changed in findutils-4.5.11 and returns no values.
rix0rrr
approved these changes
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
designfolderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.