-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stepfunctions-tasks): add sagemaker:AddTags policy for CreateTransformJob policy statements #26029
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
41eab16
to
c3bddca
Compare
Clarification Request: I could not find any place to modify any existing integration tests that would use the SageMakerCreateTransformJob as part of the state machine definition, please let me know if integration tests need to be added for this. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
This PR adds the missing sagemaker:AddTags policy for the state machine execution role when trying to create a SageMaker batch transform job using the
RUN_JOB
integration type, since the step functions service by default adds tags to the batch transform job in that scenario. More details about the problem in #26012.I could not find any place to modify any existing tests that would test the content of the state machine execution role policies when adding a batch transform job to the state machine, feel free to point me to the correct location in the codebase!
Closes #26012
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license