fix(cfnspec): IoT timestamp type by overwriting with patch

[sthuber90]

This PR provides a patch for the CloudFormation Timestamp property in AWS IoT. Here, a timestamp does not reflect a date but is an object, consisting of a Unit and Value property. By patching the IoT spec, renaming the Timestamp property type, the problem gets resolved.

Closes #22732

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[sthuber90]

Exemption Request

As the tests for cfnspec are generated I don't see the need to add custom unit or integration test logic. Let me know if you'd still like me to add tests and where you'd want them

[sthuber90]

The pull request linter fails with the following errors:

❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

I thought I followed the comment and asked for an Exemption Request request. Any help to fix the PR linter is appreciated

[sthuber90]

Ok, so after multiple iterations and trying different approaches (see commit history) it's become apparent that CDK does not like me renaming the Timestamp property to avoid breaking changes. The solution now is to keep the Timestamp property, even though it's no longer used, and add the custom IotTimestamp and use that one in the LocationActionProperty. See build log with failure message.

I don't think it's so ideal as this will result in the TimestampProperty and IotTimestampProperty being created thereby duplicating the code.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 36f6944
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[sthuber90]

@TheRealAmazonKendra or @corymhall does it makes sense that one of you reviews the PR since your also involved in another PR from me related to IoT?

[corymhall]

@TheRealAmazonKendra or @corymhall does it makes sense that one of you reviews the PR since your also involved in another PR from me related to IoT?

@sthuber90 let me check with the team on this one. I'm not sure the approach that we want to take.

[corymhall]

@TheRealAmazonKendra or @corymhall does it makes sense that one of you reviews the PR since your also involved in another PR from me related to IoT?

@sthuber90 let me check with the team on this one. I'm not sure the approach that we want to take.

@sthuber90 after discussing this with the team I think we want to handle this on the generation side since this is a case that we should be handling. I've created another PR to try and handle it.

[aws-cdk-automation]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.