Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cfnspec): update CFN specification to 3.0.0 #2492

Merged
merged 1 commit into from
May 8, 2019

Conversation

skinny85
Copy link
Contributor

@skinny85 skinny85 commented May 7, 2019

I had to remove the AWS::FSx::FileSystem.TagEntry property type and the AWS::EC2::TrunkInterfaceAssociation resource type, as they were removed from the spec.


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@skinny85 skinny85 requested a review from eladb May 7, 2019 00:19
@skinny85 skinny85 requested a review from a team as a code owner May 7, 2019 00:19
@skinny85 skinny85 force-pushed the chore/cfn-spec-update branch 2 times, most recently from fe7d3de to f5cde55 Compare May 7, 2019 00:38
@eladb
Copy link
Contributor

eladb commented May 7, 2019

You will need to add RefKinds for the new resource types.

@skinny85
Copy link
Contributor Author

skinny85 commented May 7, 2019

You will need to add RefKinds for the new resource types.

I did...? https://github.com/awslabs/aws-cdk/pull/2492/files?file-filters%5B%5D=.json#diff-bfa54cf951f85384b1d18281bf3813d6R4671

{
"op": "add",
"path": "/RefKind",
"value": "DomainName"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be just name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

@skinny85 skinny85 force-pushed the chore/cfn-spec-update branch from f5cde55 to 2cfc623 Compare May 8, 2019 17:27
@skinny85 skinny85 merged commit 0acfa8b into aws:master May 8, 2019
@skinny85 skinny85 deleted the chore/cfn-spec-update branch May 8, 2019 22:09
SanderKnape pushed a commit to SanderKnape/aws-cdk that referenced this pull request May 14, 2019
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants