fix(sfn): stop replacing JsonPath.DISCARD with null
#24717
Conversation
Follow-up to #24593. The `renderJsonPath` function is subsituting a literal `null` for `JsonPath.DISCARD`, which results in the key being dropped if the value is sent across a language boundary, which effectively changes semantics. The `JsonPath.DISCARD` value is a `Token` that ultimately resolves to `null`, and it must be preserved as such so that it is safe to exchange across languages. Thanks to @beck3905 for reporting & diagnosing this.
RomainMuller
added
the
pr-linter/exempt-integ-test
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
RomainMuller
added
the
pr-linter/exempt-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Follow-up to aws#24593. The `renderJsonPath` function is subsituting a literal `null` for `JsonPath.DISCARD`, which results in the key being dropped if the value is sent across a language boundary, which effectively changes semantics. The `JsonPath.DISCARD` value is a `Token` that ultimately resolves to `null`, and it must be preserved as such so that it is safe to exchange across languages. Thanks to @beck3905 for reporting & diagnosing this. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Use the static property `JsonPath.DISCARD` over the string `"DISCARD"`, which will cause the state's input to become its output. See: - aws/aws-cdk#24717 - https://github.com/aws/aws-cdk/blob/main/CHANGELOG.v2.md#2700-2023-03-22
Follow-up to #24593. The
renderJsonPathfunction is subsituting a literalnullforJsonPath.DISCARD, which results in the key being dropped if the value is sent across a language boundary, which effectively changes semantics.The
JsonPath.DISCARDvalue is aTokenthat ultimately resolves tonull, and it must be preserved as such so that it is safe to exchange across languages.Thanks to @beck3905 for reporting & diagnosing this.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license