Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(codepipeline-actions): add KMSEncryptionKeyARN for S3DeployAction #24536
feat(codepipeline-actions): add KMSEncryptionKeyARN for S3DeployAction #24536
Changes from 2 commits
3260703
6529ff3
464021a
c9d3e02
24490b5
9ea81e0
b384c45
53c33b1
38aec24
e49cf2c
beef056
fb2115e
d795b43
6c121fb
95ec3ac
f1251fb
7f17b89
b149706
a2db654
653d313
877715e
f04277a
9bf869e
34da951
b6a5cc6
07bd564
61af06b
50ad669
43d5690
19087b2
7a1fac5
93808a7
fc11079
20bcd5d
ebba46b
a51d6a7
b86edee
15cbd4b
1fb978a
e881279
706e00d
d3ce634
a691732
bd7ea13
0b774ce
23b7c19
7d36aa7
caea320
6016657
50bcffd
70dcf17
c0b702b
c78098a
6d9ba1a
a4bcf86
deb6217
ae5de37
b6f2c01
28ebf2a
ed84b2b
15be46c
429b97b
b63c481
db65e51
e324820
7844db7
efc0680
3835769
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than this being an ARN, we should be taking in an
IKey
here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Kendra, Thanks for reviewing this :)
I have updated the code.