Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(servicecatalogappregistry): Application Manager URL as CFN Output only if the application is created by TargetApplication.createApplicationStack #24386

Closed
wants to merge 4 commits into from
Closed

fix(servicecatalogappregistry): Application Manager URL as CFN Output only if the application is created by TargetApplication.createApplicationStack #24386

wants to merge 4 commits into from

Conversation

liwewang-amazon
Copy link
Contributor

When an application is created using Application construct, an output is automatically created in the customer defined stack without customer's intention to show related Application Manager URL for the application created. This can increase customer's CFN output usage without customer acknowledge and control.

This commit exposes the CFN Output only in the AppRegistry managed stack where the application is created to allow all the stacks deployed in the cdk project to be associated to the application.

Closes #23779

BREAKING CHANGE: This commit contains destructive changes to the RAM Share.
Since the application RAM share name is calculated by the application construct, where one property is removed. Integration test detects a breaking change where RAM share will be created. Integration test snapshot is updated to cater this destructive change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@liwewang-amazon
Create CFN output for Application Manager URL only if the application…
8aac063 
… is created by AppRegistry.

<body>

Testing done
-------------------------------------
*

Related items
------------------------------------
* SIM/auto-cut ticket
@liwewang-amazon
Change output description
59e38db 
<body>

Testing done
-------------------------------------
*

Related items
------------------------------------
* SIM/auto-cut ticket
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Feb 28, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team February 28, 2023 23:29
aws-cdk-automation
aws-cdk-automation previously requested changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@liwewang-amazon liwewang-amazon changed the title feat(servicecatalogappregistry): Application Manager URL as CFN Output only if the application is created by TargetApplication.createApplicationStack fix(servicecatalogappregistry): Application Manager URL as CFN Output only if the application is created by TargetApplication.createApplicationStack Feb 28, 2023
@liwewang-amazon
Change integ tests to replace deprecated methods.
3eac1b0 
<body>

Testing done
-------------------------------------
*

Related items
------------------------------------
* SIM/auto-cut ticket
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 28, 2023 23:57

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@TheRealAmazonKendra
Copy link
Contributor

There is already a PR in progress for this work: #24209.

Given that, I'm going to go ahead and close this as a duplicate. If that PR is closed for any reason, feel free to open another PR for this issue.

@liwewang-amazon liwewang-amazon mentioned this pull request Mar 1, 2023
Closed
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3eac1b0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

servicecatalogappregistry: Application Manager URL as string property
3 participants
@liwewang-amazon @TheRealAmazonKendra @aws-cdk-automation