feat(s3-deployment): add additional sources with addSource

[corymhall]

PR #22857 is introducing a use case where we need to be able to add additional sources after the BucketDeployment resource is created.

This PR adds an addSource method and changes all the sources evaluation within the construct to be lazy.

---

All Submissions:

• Have you followed the guidelines in our Contributing guide?

Adding new Construct Runtime Dependencies:

• This PR adds new construct runtime dependencies following the process described here

New Features

• Have you added the new feature to an integration test?
  • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 3be742a
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[moltar]

After the upgrade, getting:

Message returned: 'source_markers' and 's3_source_zips' must be the same length (RequestId: c232d0f4-b0bb-49c1-b79c-2aa0771dff42)

[moltar]

Our use case might be a bit unusual, which may cause this?

    const dummyFile = `
      -- Comment
      {{ config() }}
      SELECT 1 AS dummy
    `
    const dummyStageAssets = Source.data('/foo/bar/dummy/dummy.sql', dummyFile)
    const bucketDeploymentSoures = [dummyStageAssets, projectAssets]

    const bucketDeployment = new BucketDeployment(this, 'ProjectDeploy', {
      sources: bucketDeploymentSoures,
      destinationBucket: projectBucket,
      retainOnDelete: false,
    })

[moltar]

Which causes the following diff:

[~] Custom::CDKBucketDeployment Foo/ProjectDeploy/CustomResource ProjectDeployCustomResourceBCA514E4 
 └─ [~] SourceMarkers
     └─ @@ -1,4 +1,3 @@
        [ ] [
        [-]   {},
        [ ]   {}
        [ ] ]