fix(aws-apigateway): add optional property to spec-restapi to be able to enable compression #22990
Conversation
|
|
github-actions
bot
added
beginning-contributor
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
virajmavani
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| * | ||
| * @default - Compression is disabled. | ||
| */ | ||
| readonly minimumCompressionSize?: number; |
There was a problem hiding this comment.
Given the limitations, could you please add validation that the number provided must be in this range? Please also add unit tests (both in range and out of range) to validate this.
| * | ||
| * @default - Compression is disabled. | ||
| */ | ||
| readonly minimumCompressionSize?: number; |
There was a problem hiding this comment.
I'm also thinking that this should be moved into the base props instead of adding it individually to both RestApiProps and SpecRestApiProps.
|
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
aws-cdk-automation
added
the
closed-for-staleness
This PR addresses the feature request: #22926
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license