fix(aws-certificatemanager): no unused props for DnsValidatedCertificate

packages/@aws-cdk/aws-certificatemanager/lib/certificate-base.ts

@@ -3,6 +3,53 @@ import { Statistic } from '@aws-cdk/aws-cloudwatch';
 import { Duration, Resource } from '@aws-cdk/core';
 import { ICertificate } from './certificate';
 
+/**
+ * Shared properties for certificates
+ *
+ * @internal
+ */
+export interface BaseCertificateProps {
+  /**
+   * Fully-qualified domain name to request a certificate for.
+   *
+   * May contain wildcards, such as ``*.domain.com``.
+   */
+  readonly domainName: string;
+
+  /**
+   * Alternative domain names on your certificate.
+   *
+   * Use this to register alternative domain names that represent the same site.
+   *
+   * @default - No additional FQDNs will be included as alternative domain names.
+   */
+  readonly subjectAlternativeNames?: string[];
+
+  /**
+   * Enable or disable transparency logging for this certificate
+   *
+   * Once a certificate has been logged, it cannot be removed from the log.
+   * Opting out at that point will have no effect. If you opt out of logging
+   * when you request a certificate and then choose later to opt back in,
+   * your certificate will not be logged until it is renewed.
+   * If you want the certificate to be logged immediately, we recommend that you issue a new one.
+   *
+   * @see https://docs.aws.amazon.com/acm/latest/userguide/acm-bestpractices.html#best-practices-transparency
+   *
+   * @default true
+   */
+  readonly transparencyLoggingEnabled?: boolean;
+
+  /**
+   * The Certifcate name.
+   *
+   * Since the Certifcate resource doesn't support providing a physical name, the value provided here will be recorded in the `Name` tag
+   *
+   * @default the full, absolute path of this construct
+   */
+  readonly certificateName?: string
+}
+
 /**
  * Shared implementation details of ICertificate implementations.
  *

packages/@aws-cdk/aws-certificatemanager/lib/certificate.ts

@@ -2,7 +2,7 @@ import * as cloudwatch from '@aws-cdk/aws-cloudwatch';
 import * as route53 from '@aws-cdk/aws-route53';
 import { IResource, Token, Tags } from '@aws-cdk/core';
 import { Construct } from 'constructs';
-import { CertificateBase } from './certificate-base';
+import { CertificateBase, BaseCertificateProps } from './certificate-base';
 import { CfnCertificate } from './certificatemanager.generated';
 import { apexDomain } from './util';
 
@@ -36,23 +36,7 @@ export interface ICertificate extends IResource {
 /**
  * Properties for your certificate
  */
-export interface CertificateProps {
-  /**
-   * Fully-qualified domain name to request a certificate for.
-   *
-   * May contain wildcards, such as ``*.domain.com``.
-   */
-  readonly domainName: string;
-
-  /**
-   * Alternative domain names on your certificate.
-   *
-   * Use this to register alternative domain names that represent the same site.
-   *
-   * @default - No additional FQDNs will be included as alternative domain names.
-   */
-  readonly subjectAlternativeNames?: string[];
-
+export interface CertificateProps extends BaseCertificateProps {
   /**
    * What validation domain to use for every requested domain.
    *
@@ -77,30 +61,6 @@ export interface CertificateProps {
    * @default CertificateValidation.fromEmail()
    */
   readonly validation?: CertificateValidation;
-
-  /**
-   * Enable or disable transparency logging for this certificate
-   *
-   * Once a certificate has been logged, it cannot be removed from the log.
-   * Opting out at that point will have no effect. If you opt out of logging
-   * when you request a certificate and then choose later to opt back in,
-   * your certificate will not be logged until it is renewed.
-   * If you want the certificate to be logged immediately, we recommend that you issue a new one.
-   *
-   * @see https://docs.aws.amazon.com/acm/latest/userguide/acm-bestpractices.html#best-practices-transparency
-   *
-   * @default true
-   */
-  readonly transparencyLoggingEnabled?: boolean;
-
-  /**
-   * The Certifcate name.
-   *
-   * Since the Certifcate resource doesn't support providing a physical name, the value provided here will be recorded in the `Name` tag
-   *
-   * @default the full, absolute path of this construct
-   */
-  readonly certificateName?: string
 }
 
 /**

packages/@aws-cdk/aws-certificatemanager/lib/dns-validated-certificate.ts

@@ -4,14 +4,14 @@ import * as lambda from '@aws-cdk/aws-lambda';
 import * as route53 from '@aws-cdk/aws-route53';
 import * as cdk from '@aws-cdk/core';
 import { Construct } from 'constructs';
-import { CertificateProps, ICertificate } from './certificate';
-import { CertificateBase } from './certificate-base';
+import { ICertificate } from './certificate';
+import { CertificateBase, BaseCertificateProps } from './certificate-base';
 
 /**
  * Properties to create a DNS validated certificate managed by AWS Certificate Manager
  *
  */
-export interface DnsValidatedCertificateProps extends CertificateProps {
+export interface DnsValidatedCertificateProps extends BaseCertificateProps {
   /**
    * Route 53 Hosted Zone used to perform DNS validation of the request.  The zone
    * must be authoritative for the domain name specified in the Certificate Request.

packages/@aws-cdk/aws-certificatemanager/test/integ.dns-validated-certificate.ts

@@ -1,7 +1,7 @@
 import { PublicHostedZone } from '@aws-cdk/aws-route53';
 import { App, Stack, RemovalPolicy, CfnOutput, Fn } from '@aws-cdk/core';
 import { IntegTest } from '@aws-cdk/integ-tests';
-import { DnsValidatedCertificate, CertificateValidation } from '../lib';
+import { DnsValidatedCertificate } from '../lib';
 
 /**
  * In order to test this you need to have a valid public hosted zone that you can use
@@ -36,7 +36,6 @@ const hostedZone = PublicHostedZone.fromHostedZoneAttributes(stack, 'HostedZone'
 const cert = new DnsValidatedCertificate(stack, 'Certificate', {
   domainName,
   hostedZone,
-  validation: CertificateValidation.fromDns(hostedZone),
 });
 cert.applyRemovalPolicy(RemovalPolicy.RETAIN);
 new CfnOutput(stack, 'CertificateArn', {