Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eks): support for Kubernetes version 1.23 #22638
feat(eks): support for Kubernetes version 1.23 #22638
Changes from 53 commits
c93ed9d
d1e4a58
d184727
3e985be
4c1b57b
0696a37
f1a484a
9892f6a
e821907
a0b1d71
6ebd1b6
4e8c7ee
888db08
b782726
7bf6b0d
11bf39e
9f9db94
67da92b
cdf5d1d
9d89f1a
bfa8d82
098af04
39fc1ac
b98823f
9bc19f5
87dd8dc
9e7169b
6d07cc1
083d849
5360272
615e271
1279bde
9b9dec7
1a654de
68e8d60
f55ca4a
bb1819c
bc9b3fc
5b12477
fc3764e
9c02969
6d961b5
cb1b11e
cc477ce
c3461ba
10d85ba
b9622a9
fbf9939
930212d
af3362c
84c7e9e
cba6fe2
6dc385e
97281d2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it that it may cause errors or that it will? If we know it will, I think this should be an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If not, no issues here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not for certain. In some cases you can use a version of kubectl that is not guaranteed to be compatible with the version of the Kubernetes engine you are using. It just depends on the APIs being used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a concern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, a lambda layer is a stateless resource, and we are replacing it with an upgraded version of kubectl. So, the replacement is expected here.