fix(iam): oidc provider retrieves leaf certificate instead of root certificate #22509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vinayak Kukreja <[email protected]>
Signed-off-by: Vinayak Kukreja <[email protected]>
Signed-off-by: Vinayak Kukreja <[email protected]>
|
|
aws-cdk-automation
previously requested changes
Oct 14, 2022
Signed-off-by: Vinayak Kukreja <[email protected]>
Signed-off-by: Vinayak Kukreja <[email protected]>
vinayak-kukreja
changed the title
Signed-off-by: Vinayak Kukreja <[email protected]>
comcalvi
reviewed
Oct 14, 2022
Signed-off-by: Vinayak Kukreja <[email protected]>
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
vinayak-kukreja
requested review from
TheRealAmazonKendra,
comcalvi and
iliapolo
4 tasks
vinayak-kukreja
added
the
pr/do-not-merge
comcalvi
requested changes
Nov 3, 2022
vinayak-kukreja
force-pushed
the
vkukreja/oidc-provider-fix
branch
2 times, most recently
from
6d67d83
to
2951eeb
Compare
iliapolo
changed the title
github-actions
bot
added
the
effort/medium
Signed-off-by: Vinayak Kukreja <[email protected]>
vinayak-kukreja
force-pushed
the
vkukreja/oidc-provider-fix
branch
from
2951eeb
to
0a5caa8
Compare
aws-cdk-automation
previously requested changes
Nov 3, 2022
Signed-off-by: Vinayak Kukreja <[email protected]>
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
iliapolo
approved these changes
Nov 4, 2022
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Naumel
pushed a commit
that referenced
this pull request
Nov 4, 2022
…rtificate (#22509) Currently, the IAM OIDC Provider is retrieving leaf certificates for a given url. The validity for these certificates is not that long. This can cause an outage for the customer since they might not be aware of when the certificate is going to expire. We have seen an [outage](#8607) in EKS due to this issue. This change will help retrieving root certificates instead of leaf certificates. The validity of root certificate is much more than the leaf certificates. I am also adding validations for the certificate and also informing the customer if there retrieved certificate is going to expire within six months when they do a new deployment. Fixes #8607 Signed-off-by: Vinayak Kukreja <[email protected]> ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the IAM OIDC Provider is retrieving leaf certificates for a given url. The validity for these certificates is not that long. This can cause an outage for the customer since they might not be aware of when the certificate is going to expire. We have seen an outage in EKS due to this issue.
This change will help retrieving root certificates instead of leaf certificates. The validity of root certificate is much more than the leaf certificates. I am also adding validations for the certificate and also informing the customer if there retrieved certificate is going to expire within six months when they do a new deployment.
Fixes #8607
Signed-off-by: Vinayak Kukreja [email protected]
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license