Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-glue): add glue view support #22459

Closed
wants to merge 1 commit into from
Closed

feat(aws-glue): add glue view support #22459

wants to merge 1 commit into from

Conversation

JeromeGuyon
Copy link
Contributor

@JeromeGuyon JeromeGuyon commented Oct 11, 2022

Glue view support

fixes #19496


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 11, 2022

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Oct 11, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team October 11, 2022 09:42
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@JeromeGuyon JeromeGuyon changed the title add glue view support feat(aws-glue): add glue view support Oct 11, 2022
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 11, 2022 09:58

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@Naumel Naumel added the @aws-cdk/aws-glue Related to AWS Glue label Oct 13, 2022
@TheRealAmazonKendra TheRealAmazonKendra changed the title feat(aws-glue): add glue view support feat(glue): add glue view support Oct 13, 2022
@TheRealAmazonKendra TheRealAmazonKendra marked this pull request as draft October 13, 2022 19:53
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a new L2, which requires an approved RFC. Putting this in draft mode until the RFC process has been completed.

@TheRealAmazonKendra TheRealAmazonKendra self-assigned this Oct 19, 2022
@pahud
Copy link
Contributor

pahud commented Oct 19, 2022

Hi @JeromeGuyon do you need any help on the RFC? I hope this will not be a blocker for your contribution. Let me know if you need a chat. You can reach out to me on cdk.dev slack or twitter.

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@JeromeGuyon JeromeGuyon changed the title feat(glue): add glue view support feat(aws-glue): add glue view support Nov 4, 2022
@mergify mergify bot dismissed TheRealAmazonKendra’s stale review November 4, 2022 11:56

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e14108d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@JeromeGuyon
Copy link
Contributor Author

Hi @JeromeGuyon do you need any help on the RFC? I hope this will not be a blocker for your contribution. Let me know if you need a chat. You can reach out to me on cdk.dev slack or twitter.

Hi @pahud and thank you for you support.
I just created the RFC

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-glue Related to AWS Glue beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(glue): L2 View Construct
5 participants