Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cfnspec): cloudformation spec v88.0.0 #22026

Merged
merged 5 commits into from
Sep 14, 2022
Merged

Conversation

aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Sep 13, 2022

No description provided.

@aws-cdk-automation aws-cdk-automation added auto-approve pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Sep 13, 2022
@gitpod-io
Copy link

gitpod-io bot commented Sep 13, 2022

@github-actions github-actions bot added the p2 label Sep 13, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team September 13, 2022 22:34
… an attribute property

This is a new attribute that was added to the SubscriptionFilter resource in cfnspec v88.0.0.
Adding properties to L2s is out of scope for cfnspec PRs, so adding an exception to the awslint
rule.
github-actions[bot]
github-actions bot previously approved these changes Sep 13, 2022
@mergify mergify bot dismissed github-actions[bot]’s stale review September 13, 2022 23:32

Pull request has been modified.

github-actions[bot]
github-actions bot previously approved these changes Sep 14, 2022
@mergify mergify bot dismissed github-actions[bot]’s stale review September 14, 2022 17:41

Pull request has been modified.

github-actions[bot]
github-actions bot previously approved these changes Sep 14, 2022
@mergify mergify bot dismissed github-actions[bot]’s stale review September 14, 2022 19:53

Pull request has been modified.

github-actions[bot]
github-actions bot previously approved these changes Sep 14, 2022
@mergify mergify bot dismissed github-actions[bot]’s stale review September 14, 2022 20:47

Pull request has been modified.

@madeline-k
Copy link
Contributor

Tests failed with:

time="2022-09-14T20:11:22.820982594Z" level=info msg="Attempting next endpoint for pull after error: received unexpected HTTP status: 504 Gateway Time-out"
@aws-cdk/aws-s3-deployment: received unexpected HTTP status: 504 Gateway Time-out

Hopefully this is a transient timeout, re-running the build. the aws-s3-deployment module succeeds on my local machine.

@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: dfe03a7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1f03e8c into main Sep 14, 2022
@mergify mergify bot deleted the bump-cfnspec-main/v88.0.0 branch September 14, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-approve p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants