fix(elasticloadbalancingv2): securityGroup property is not required in fromApplicationListenerAttributes

packages/@aws-cdk/aws-elasticloadbalancingv2/lib/alb/application-listener.ts

@@ -556,17 +556,10 @@ export interface ApplicationListenerAttributes {
    */
   readonly listenerArn: string;
 
-  /**
-   * Security group ID of the load balancer this listener is associated with
-   *
-   * @deprecated use `securityGroup` instead
-   */
-  readonly securityGroupId?: string;
-
   /**
    * Security group of the load balancer this listener is associated with
    */
-  readonly securityGroup?: ec2.ISecurityGroup;
+  readonly securityGroup: ec2.ISecurityGroup;
 
   /**
    * The default port on which this listener is listening
@@ -709,19 +702,8 @@ class ImportedApplicationListener extends ExternalApplicationListener {
     this.listenerArn = props.listenerArn;
     const defaultPort = props.defaultPort !== undefined ? ec2.Port.tcp(props.defaultPort) : undefined;
 
-    let securityGroup: ec2.ISecurityGroup;
-    if (props.securityGroup) {
-      securityGroup = props.securityGroup;
-    } else if (props.securityGroupId) {
-      securityGroup = ec2.SecurityGroup.fromSecurityGroupId(this, 'SecurityGroup', props.securityGroupId, {
-        allowAllOutbound: props.securityGroupAllowsAllOutbound,
-      });
-    } else {
-      throw new Error('Either `securityGroup` or `securityGroupId` must be specified to import an application listener.');
-    }
-
     this.connections = new ec2.Connections({
-      securityGroups: [securityGroup],
+      securityGroups: [props.securityGroup],
       defaultPort,
     });
   }

packages/@aws-cdk/aws-elasticloadbalancingv2/test/alb/listener.test.ts

@@ -755,6 +755,37 @@ describe('tests', () => {
     });
   });
 
+  test('imported listener only need securityGroup and listenerArn as attributes', () => {
+    // GIVEN
+    const stack = new cdk.Stack();
+
+    const importedListener = elbv2.ApplicationListener.fromApplicationListenerAttributes(stack, 'listener', {
+      listenerArn: 'listener-arn',
+      defaultPort: 443,
+      securityGroup: ec2.SecurityGroup.fromSecurityGroupId(stack, 'SG', 'security-group-id', {
+        allowAllOutbound: false,
+      }),
+    });
+    importedListener.addAction('Hello', {
+      action: elbv2.ListenerAction.fixedResponse(503),
+      conditions: [elbv2.ListenerCondition.pathPatterns(['/hello'])],
+      priority: 10,
+    });
+
+    Template.fromStack(stack).hasResourceProperties('AWS::ElasticLoadBalancingV2::ListenerRule', {
+      ListenerArn: 'listener-arn',
+      Priority: 10,
+      Actions: [
+        {
+          FixedResponseConfig: {
+            StatusCode: '503',
+          },
+          Type: 'fixed-response',
+        },
+      ],
+    });
+  });
+
   test('Can add actions to an imported listener', () => {
     // GIVEN
     const stack = new cdk.Stack();