fix(codepipeline-actions): ecr source action doesn't trigger the pipeline #21580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…line When the ECR source action was initially released, ECR did not yet integrate with EventBridge so it was necessary to use CloudTrail. Since then ECR was updated to integrate with EventBridge so relying on CloudTrail is no longer necessary. This PR changes the event rule that triggers the pipeline to use the `ECR Image Action` instead of the CloudTrail event. This change does lead to the `AWS::Events::Rule` resource being deleted and recreated, but that should not cause any issues since there is no state involved. I tested this by using the integ test and manually validated that pushing an image to the ecr repo triggers the pipeline. The steps are outlined in the `integ.pipeline-ecr-source.ts` file. fix #10901
|
|
github-actions
bot
added
bug
rix0rrr
approved these changes
Aug 12, 2022
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
josephedward
pushed a commit
to josephedward/aws-cdk
that referenced
this pull request
Aug 30, 2022
…line (aws#21580) When the ECR source action was initially released, ECR did not yet integrate with EventBridge so it was necessary to use CloudTrail. Since then ECR was updated to integrate with EventBridge so relying on CloudTrail is no longer necessary. This PR changes the event rule that triggers the pipeline to use the `ECR Image Action` instead of the CloudTrail event. This change does lead to the `AWS::Events::Rule` resource being deleted and recreated, but that should not cause any issues since there is no state involved. I tested this by using the integ test and manually validated that pushing an image to the ecr repo triggers the pipeline. The steps are outlined in the `integ.pipeline-ecr-source.ts` file. fix aws#10901 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the ECR source action was initially released, ECR did not yet
integrate with EventBridge so it was necessary to use CloudTrail.
Since then ECR was updated to integrate with EventBridge so relying on
CloudTrail is no longer necessary.
This PR changes the event rule that triggers the pipeline to use the
ECR Image Actioninstead of the CloudTrail event.This change does lead to the
AWS::Events::Ruleresource being deletedand recreated, but that should not cause any issues since there is no
state involved. I tested this by using the integ test and manually
validated that pushing an image to the ecr repo triggers the pipeline.
The steps are outlined in the
integ.pipeline-ecr-source.tsfile.fix #10901
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license