Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): expose interface endpoint service shortname #20965

Merged
merged 2 commits into from
Jul 6, 2022
Merged

feat(ec2): expose interface endpoint service shortname #20965

merged 2 commits into from
Jul 6, 2022

Conversation

hoegertn
Copy link
Contributor

@hoegertn hoegertn commented Jul 2, 2022

This PR exposes the short name of the InterfaceVpcEndpointService as an additional property. This helps constructs getting it as a param to derive the service name without parsing regional reverse-FQDNs.

As it only adds a property, I think no readme change is needed here.


All Submissions:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 2, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team July 2, 2022 14:10
@github-actions github-actions bot added the p2 label Jul 2, 2022
@hoegertn
Copy link
Contributor Author

hoegertn commented Jul 2, 2022

/cc @corymhall

Would love to have a review here.

@corymhall corymhall added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jul 5, 2022
corymhall
corymhall previously approved these changes Jul 5, 2022
@mergify mergify bot dismissed corymhall’s stale review July 6, 2022 20:34

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5c98510
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ebfbf54 into aws:main Jul 6, 2022
daschaa pushed a commit to daschaa/aws-cdk that referenced this pull request Jul 9, 2022
This PR exposes the short name of the InterfaceVpcEndpointService as an additional property. This helps constructs getting it as a param to derive the service name without parsing regional reverse-FQDNs.

As it only adds a property, I think no readme change is needed here.

----

### All Submissions:

* [X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)


*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants