Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoscaling): step scaling policy supports estimatedInstanceWarmup property #20936

Merged
merged 2 commits into from
Jul 1, 2022

Conversation

BDeus
Copy link
Contributor

@BDeus BDeus commented Jun 30, 2022

Fix #10514


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 30, 2022

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Jun 30, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team June 30, 2022 15:30
@kaizencc kaizencc changed the title Add missing estimatedInstanceWarmup properties on step scaling policy feat(autoscaling): step scaling policy supports estimatedInstanceWarmup property Jun 30, 2022
@kaizencc kaizencc added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jun 30, 2022
@kaizencc kaizencc added the pr-linter/exempt-readme The PR linter will not require README changes label Jul 1, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 1, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 001e392
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e4c7b97 into aws:main Jul 1, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 1, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@BDeus BDeus deleted the estimatedInstanceWarmup branch July 2, 2022 13:51
daschaa pushed a commit to daschaa/aws-cdk that referenced this pull request Jul 9, 2022
…up property (aws#20936)

Fix aws#10514

----

### All Submissions:

* [ x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[autoscaling] StepScalingPolicy ignores estimatedInstanceWarmup property
3 participants