Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cfnspec): Add coverage directory to npmignore (backport #20016) #20931

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 30, 2022

This is an automatic backport of pull request #20016 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Installing cfnspec shows the coverage directory is being published to npm. I assume this should be excluded since build artifacts aren't typically published, and at a glance most CDK packages exclude any build artifacts from the published package. (If there is a specific reason why the coverage folder is being published, please advise since I'd be interested to understand the use case.)

```
$ npm install @aws-cdk/cfnspec
$ ls -1 node_modules/@aws-cdk/cfnspec/
CHANGELOG.md
LICENSE
coverage
lib
package.json
...
$  ls -1 node_modules/@aws-cdk/cfnspec/coverage
base.css
block-navigation.js
build-tools
favicon.png
index.html
junit.xml
...
```
----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* N/A

### New Features

* N/A

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

(cherry picked from commit f15b18a)
@gitpod-io
Copy link

gitpod-io bot commented Jun 30, 2022

@github-actions github-actions bot added the p2 label Jun 30, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team June 30, 2022 09:28
@mergify
Copy link
Contributor Author

mergify bot commented Jun 30, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7a7ca65
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a3c1a5d into main Jun 30, 2022
@mergify mergify bot deleted the mergify/bp/main/pr-20016 branch June 30, 2022 13:51
@mergify
Copy link
Contributor Author

mergify bot commented Jun 30, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

daschaa pushed a commit to daschaa/aws-cdk that referenced this pull request Jul 9, 2022
…) (aws#20931)

This is an automatic backport of pull request aws#20016 done by [Mergify](https://mergify.com).


---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the [documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants