fix(secretsmanager): SecretRotation app does not set DeletionPolicy #20901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internal Amazon campaigns are validating that all `AWS::Serverless::Application` resources have `DeletionPolicy` set. Since `AWS::Serverless::Application` is not classified as a stateful resource by our metadata (nor could/should it be, because who knows?) we don't benefit from the automatic support for these policies from our model. Instead, manually add the required `Delete` policies on the `CfnApplication`.
|
|
comcalvi
approved these changes
Jun 29, 2022
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
daschaa
pushed a commit
to daschaa/aws-cdk
that referenced
this pull request
Jul 9, 2022
…ws#20901) Internal Amazon campaigns are validating that all `AWS::Serverless::Application` resources have `DeletionPolicy` set. Since `AWS::Serverless::Application` is not classified as a stateful resource by our metadata (nor could/should it be, because who knows?) we don't benefit from the automatic support for these policies from our model. Instead, manually add the required `Delete` policies on the `CfnApplication`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal Amazon campaigns are validating that all
AWS::Serverless::Applicationresources haveDeletionPolicyset.Since
AWS::Serverless::Applicationis not classified as a statefulresource by our metadata (nor could/should it be, because who knows?)
we don't benefit from the automatic support for these policies from
our model.
Instead, manually add the required
Deletepolicies on theCfnApplication.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license