Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cognito): make grant() available on IUserPool #20799

Merged
merged 3 commits into from
Jun 29, 2022

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Jun 20, 2022

Added in #20285 but missing on IUserPool


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 20, 2022

@github-actions github-actions bot added the p2 label Jun 20, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team June 20, 2022 10:44
@corymhall corymhall changed the title chore(cognito): make grant() available on IUserPool feat(cognito): make grant() available on IUserPool Jun 27, 2022
@jogold
Copy link
Contributor Author

jogold commented Jun 28, 2022

@corymhall I see you made it a feat, can you exempt it from a README entry then?

@corymhall corymhall added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jun 28, 2022
@jogold
Copy link
Contributor Author

jogold commented Jun 29, 2022

@corymhall I see you made it a feat, can you exempt it from a README entry then?

and pr-linter/exempt-test and approve 😄?

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 42af119
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@corymhall corymhall added the pr-linter/exempt-test The PR linter will not require test changes label Jun 29, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 29, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a1df570 into aws:main Jun 29, 2022
daschaa pushed a commit to daschaa/aws-cdk that referenced this pull request Jul 9, 2022
Added in aws#20285 but missing on `IUserPool`

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@jogold jogold deleted the iuserpool-grant branch July 13, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants