fix(iam): duplicate PolicyStatements lead to too many overflow policies #20767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Historically, policy statement deduplicating was done during policy rendering. There could be a 100 statements in a policy, but if they were all the same it would only render as 1 statement. When we introduced policy splitting, those 100 equal statements would *first* be divided into Overflow policies before being deduplicated (potentially leading to too many policies being created, hitting limits). Especially CDK Pipelines takes heavy advantage of the deduplicating behavior, and adds the same policies over and over again, leading to overflows. When the `minimizePolicies` feature flag is turned on, duplicate elimitation is implicitly performed (because equal statements count as mergeable), but when the feature flag is off we hit the bad behavior. As a fix, do deduplication even if merging is turned off.
|
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
corymhall
approved these changes
Jun 16, 2022
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
4 tasks
daschaa
pushed a commit
to daschaa/aws-cdk
that referenced
this pull request
Jul 9, 2022
…es (aws#20767) Historically, policy statement deduplicating was done during policy rendering. There could be a 100 statements in a policy, but if they were all the same it would only render as 1 statement. When we introduced policy splitting, those 100 equal statements would *first* be divided into Overflow policies before being deduplicated (potentially leading to too many policies being created, hitting limits). Especially CDK Pipelines takes heavy advantage of the deduplicating behavior, and adds the same policies over and over again, leading to overflows. When the `minimizePolicies` feature flag is turned on, duplicate elimitation is implicitly performed (because equal statements count as mergeable), but when the feature flag is off we hit the bad behavior. As a fix, do deduplication even if merging is turned off. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, policy statement deduplicating was done during policy
rendering. There could be a 100 statements in a policy, but if they
were all the same it would only render as 1 statement.
When we introduced policy splitting, those 100 equal statements would
first be divided into Overflow policies before being deduplicated
(potentially leading to too many policies being created, hitting limits).
Especially CDK Pipelines takes heavy advantage of the deduplicating
behavior, and adds the same policies over and over again, leading
to overflows.
When the
minimizePoliciesfeature flag is turned on, duplicateelimitation is implicitly performed (because equal statements
count as mergeable), but when the feature flag is off we
hit the bad behavior.
As a fix, do deduplication even if merging is turned off.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license