Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): remove excess whitespace #20664

Merged
merged 2 commits into from
Jun 8, 2022
Merged

chore(core): remove excess whitespace #20664

merged 2 commits into from
Jun 8, 2022

Conversation

kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Jun 8, 2022

This was getting on my nerves. The whitespace comes from migrating our testing suite to jest -- some of our automated migration scripts must have neglected to remove the excess new lines. Added a few new lines for formatting fidelity as well, which is what accounts for the + file diff.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 8, 2022

@kaizencc kaizencc requested a review from a team June 8, 2022 14:57
@aws-cdk-automation aws-cdk-automation requested a review from a team June 8, 2022 14:57
@github-actions github-actions bot added the p2 label Jun 8, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 8, 2022
Copy link
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! thank you

@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3d5ad25
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0533dc7 into main Jun 8, 2022
@mergify mergify bot deleted the conroy/snapshot branch June 8, 2022 16:38
daschaa pushed a commit to daschaa/aws-cdk that referenced this pull request Jul 9, 2022
This was getting on my nerves. The whitespace comes from migrating our testing suite to jest -- some of our automated migration scripts must have neglected to remove the excess new lines. Added a few new lines for formatting fidelity as well, which is what accounts for the + file diff.

----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants