Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): allow specifying Docker build targets #20654

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

indrora
Copy link
Contributor

@indrora indrora commented Jun 7, 2022

Adds the ability to pass --target [...] to the build parameters of a Docker container. This is useful when there is a prod and a dev target that can be built differently.

Closes #20143


All Submissions:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 7, 2022

@github-actions github-actions bot added feature-request A feature should be added or improved. p2 labels Jun 7, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team June 7, 2022 21:27
@Chriscbr Chriscbr changed the title feat(@aws-cdk/core): Allow specifying Docker build targets feat(core): Allow specifying Docker build targets Jun 7, 2022
@Chriscbr Chriscbr changed the title feat(core): Allow specifying Docker build targets feat(core): allow specifying Docker build targets Jun 7, 2022
@indrora indrora enabled auto-merge (squash) June 7, 2022 21:52
@indrora indrora merged commit f243f9e into aws:main Jun 7, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2ad90e4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

daschaa pushed a commit to daschaa/aws-cdk that referenced this pull request Jul 9, 2022
Add support for passing `--target [...]` to docker build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundling: cannot set target from Dockerfile
3 participants