Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clarify .Net core versions in contributing guide #20612

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

philipmw
Copy link
Contributor

@philipmw philipmw commented Jun 3, 2022

I spent some time installing .Net Core 3.1.x on my Mac and struggling with
unsigned binaries before I discovered that the latest version works.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 3, 2022

@github-actions github-actions bot added the p2 label Jun 3, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team June 3, 2022 14:48
I spent some time installing .Net Core 3.1.x on my Mac and struggling with
unsigned binaries before I discovered that the latest version works.
@kaizencc kaizencc changed the title chore(core): clarify .Net core versions in contributing guide chore: clarify .Net core versions in contributing guide Jun 6, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9fb1dba
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5696c5d into aws:main Jun 8, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@philipmw philipmw deleted the dotnet branch June 16, 2022 16:52
daschaa pushed a commit to daschaa/aws-cdk that referenced this pull request Jul 9, 2022
I spent some time installing .Net Core 3.1.x on my Mac and struggling with
unsigned binaries before I discovered that the latest version works.


----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants