feat(codebuild): adds report group type property #20178

daschaa · 2022-05-02T19:26:49Z

fixes #14279.
Introduces optional property to the ReportGroup to define the type of the report group (either 'TEST' or 'CODE_COVERAGE'). It just passes down the property to the underlying CfnReportGroup.

All Submissions:

Have you followed the guidelines in our Contributing guide?

Adding new Unconventional Dependencies:

This PR adds new unconventional dependencies following the process described here

New Features

Have you added the new feature to an integration test?
- Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

gitpod-io · 2022-05-02T19:26:55Z

rix0rrr · 2022-05-19T12:34:54Z

packages/@aws-cdk/aws-codebuild/lib/report-group.ts

+   *
+   * @default - TEST
+   */
+  readonly type?: 'TEST' | 'CODE_COVERAGE'


Please introduce an enum type

Done! I was not sure about the documentation tho. Is this ok? I tried to reuse to text which is in the CloudFormation documentation.
Thanks you for your review! ❤️

Pull request has been modified.

daschaa · 2022-05-20T12:57:20Z

@rix0rrr Does this need to have a change in the README file?

Pull request has been modified.

daschaa · 2022-05-24T20:29:46Z

@rix0rrr I have now added the information to the package README file. Could you please review it again? Thanks in advance!

packages/@aws-cdk/aws-codebuild/README.md

Co-authored-by: Calvin Combs <[email protected]>

Pull request has been modified.

daschaa · 2022-06-01T14:04:04Z

@rix0rrr @comcalvi Can this be merged? :)

comcalvi

Almost there! A small change and this should be ready to merge.

packages/@aws-cdk/aws-codebuild/lib/report-group.ts

packages/@aws-cdk/aws-codebuild/test/report-group.test.ts

…/lambda-layer-awscli (aws#20580) Bumps [awscli](https://github.com/aws/aws-cli) from 1.24.10 to 1.25.1. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cli/blob/develop/CHANGELOG.rst">awscli's changelog</a>.</em></p> <blockquote> <h1>1.25.1</h1> <ul> <li>api-change:<code>route53</code>: Add new APIs to support Route 53 IP Based Routing</li> <li>api-change:<code>forecast</code>: Added Format field to Import and Export APIs in Amazon Forecast. Added TimeSeriesSelector to Create Forecast API.</li> <li>api-change:<code>chime-sdk-meetings</code>: Adds support for centrally controlling each participant's ability to send and receive audio, video and screen share within a WebRTC session. Attendee capabilities can be specified when the attendee is created and updated during the session with the new BatchUpdateAttendeeCapabilitiesExcept API.</li> <li>api-change:<code>backup-gateway</code>: Adds GetGateway and UpdateGatewaySoftwareNow API and adds hypervisor name to UpdateHypervisor API</li> </ul> <h1>1.25.0</h1> <ul> <li>api-change:<code>lookoutmetrics</code>: Adding backtest mode to detectors using the Cloudwatch data source.</li> <li>api-change:<code>transcribe</code>: Amazon Transcribe now supports automatic language identification for multi-lingual audio in batch mode.</li> <li>api-change:<code>iotsitewise</code>: This release adds the following new optional field to the IoT SiteWise asset resource: assetDescription.</li> <li>api-change:<code>sagemaker</code>: Amazon SageMaker Notebook Instances now support Jupyter Lab 3.</li> <li>feature:Python: Dropped support for Python 3.6</li> <li>api-change:<code>drs</code>: Changed existing APIs and added new APIs to accommodate using multiple AWS accounts with AWS Elastic Disaster Recovery.</li> <li>api-change:<code>cognito-idp</code>: Amazon Cognito now supports IP Address propagation for all unauthenticated APIs (e.g. SignUp, ForgotPassword).</li> <li>feature:Python: Dropped support for Python 3.6</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/aws/aws-cli/commit/bdb30cbc185ecd85c298a9a02a5e62c2dbbb0fed"><code>bdb30cb</code></a> Merge branch 'release-1.25.1'</li> <li><a href="https://github.com/aws/aws-cli/commit/cbd71ef95e0a68105eef5f9c01a764ab8618b917"><code>cbd71ef</code></a> Bumping version to 1.25.1</li> <li><a href="https://github.com/aws/aws-cli/commit/8d8b95686fe244ded215822c6587d938c35b8ea2"><code>8d8b956</code></a> Update changelog based on model updates</li> <li><a href="https://github.com/aws/aws-cli/commit/eab8942277bd2eb00c75911e2ee412d09c6e9bf1"><code>eab8942</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/aws/aws-cli/issues/5568">#5568</a> from ConnorKirk/add-codecommit-repository-to-cloudfo...</li> <li><a href="https://github.com/aws/aws-cli/commit/e6f13292f5714573275d03bb23be9e1ec05bb371"><code>e6f1329</code></a> Add CodeCommit::Repository to cfn package command</li> <li><a href="https://github.com/aws/aws-cli/commit/9b940e82b934a65fb6f89bdd5ed03f8e7d4dcb70"><code>9b940e8</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/aws/aws-cli/issues/5576">#5576</a> from joel-aws/package-serverless-states-definitionuri</li> <li><a href="https://github.com/aws/aws-cli/commit/042929e777b748d78bbefef09178de11ad678715"><code>042929e</code></a> Support exporting DefinitionUri in AWS::Serverless::StateMachine resource</li> <li><a href="https://github.com/aws/aws-cli/commit/f73c533e37d5b89660b796177764c17dbd8e52af"><code>f73c533</code></a> Merge branch 'release-1.25.0'</li> <li><a href="https://github.com/aws/aws-cli/commit/23e4b4fabf30ca460a115ac4c4724c6b03bf0a23"><code>23e4b4f</code></a> Merge branch 'release-1.25.0' into develop</li> <li><a href="https://github.com/aws/aws-cli/commit/f6f635ce8a6664ac6c8424d1ad9f3298dff9dfba"><code>f6f635c</code></a> Bumping version to 1.25.0</li> <li>Additional commits viewable in <a href="https://github.com/aws/aws-cli/compare/1.24.10...1.25.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=awscli&package-manager=pip&previous-version=1.24.10&new-version=1.25.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

Co-authored-by: Calvin Combs <[email protected]>

daschaa · 2022-06-02T06:51:10Z

@comcalvi I commited your suggestion regarding the JSDoc and implemented a test for the default report group type 😊 Could you review it again please? Thanks in advance! ❤️

daschaa · 2022-06-03T19:59:15Z

@comcalvi I changed the target brach to "main" - I hope it is ok, because I saw in other PR's it was done automatically..

mergify · 2022-06-03T22:38:32Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2022-06-03T23:14:09Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 68abc39
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2022-06-03T23:14:23Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

fixes aws#14279. Introduces optional property to the ReportGroup to define the type of the report group (either 'TEST' or 'CODE_COVERAGE'). It just passes down the property to the underlying CfnReportGroup. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [x] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

🧑‍💻 Adds report group type property

c07ff3e

aws-cdk-automation requested a review from a team May 2, 2022 19:27

aws-cdk-automation assigned kaizencc May 2, 2022

github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 labels May 2, 2022

daschaa force-pushed the report-group-type branch from b66b093 to c07ff3e Compare May 2, 2022 20:24

daschaa added 3 commits May 2, 2022 22:25

Merge branch 'master' into report-group-type

607ee66

Merge branch 'master' into report-group-type

24919e0

Merge branch 'master' into report-group-type

eb0021b

kaizencc assigned Naumel and unassigned kaizencc May 17, 2022

rix0rrr previously requested changes May 19, 2022

View reviewed changes

daschaa and others added 2 commits May 19, 2022 20:41

♻️ Adds enum type for report group type

a8797bd

Merge branch 'master' into report-group-type

5d730fd

rix0rrr added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label May 20, 2022

rix0rrr previously approved these changes May 20, 2022

View reviewed changes

rix0rrr added effort/small Small work item – less than a day of effort and removed effort/medium Medium work item – several days of effort labels May 20, 2022

daschaa and others added 2 commits May 24, 2022 22:28

📝 Adds code coverage report type to README

60a94c7

Merge branch 'master' into report-group-type

e1011cd

comcalvi previously requested changes May 24, 2022

View reviewed changes

packages/@aws-cdk/aws-codebuild/README.md Outdated Show resolved Hide resolved

Update packages/@aws-cdk/aws-codebuild/README.md

9f023e4

Co-authored-by: Calvin Combs <[email protected]>

comcalvi requested changes Jun 1, 2022

View reviewed changes

packages/@aws-cdk/aws-codebuild/lib/report-group.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-codebuild/test/report-group.test.ts Show resolved Hide resolved

dependabot bot and others added 4 commits June 1, 2022 22:32

Update packages/@aws-cdk/aws-codebuild/lib/report-group.ts

21eec99

Co-authored-by: Calvin Combs <[email protected]>

✅ Adds test for default report group type

327f07c

Merge branch 'v1-main' into report-group-type

f888b5b

daschaa changed the base branch from v1-main to main June 2, 2022 17:45

Merge branch 'main' into report-group-type

23e6a63

github-actions bot added effort/medium Medium work item – several days of effort and removed effort/small Small work item – less than a day of effort labels Jun 2, 2022

comcalvi approved these changes Jun 3, 2022

View reviewed changes

Merge branch 'main' into report-group-type

68abc39

mergify bot merged commit 15bcc3c into aws:main Jun 3, 2022

daschaa deleted the report-group-type branch June 4, 2022 07:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(codebuild): adds report group type property #20178

feat(codebuild): adds report group type property #20178

daschaa commented May 2, 2022 •

edited

Loading

gitpod-io bot commented May 2, 2022

rix0rrr May 19, 2022

daschaa May 19, 2022

daschaa commented May 20, 2022

daschaa commented May 24, 2022

daschaa commented Jun 1, 2022

comcalvi left a comment

daschaa commented Jun 2, 2022

daschaa commented Jun 3, 2022

mergify bot commented Jun 3, 2022

aws-cdk-automation commented Jun 3, 2022

mergify bot commented Jun 3, 2022

feat(codebuild): adds report group type property #20178

feat(codebuild): adds report group type property #20178

Conversation

daschaa commented May 2, 2022 • edited Loading

All Submissions:

Adding new Unconventional Dependencies:

New Features

gitpod-io bot commented May 2, 2022

rix0rrr May 19, 2022

Choose a reason for hiding this comment

daschaa May 19, 2022

Choose a reason for hiding this comment

daschaa commented May 20, 2022

daschaa commented May 24, 2022

daschaa commented Jun 1, 2022

comcalvi left a comment

Choose a reason for hiding this comment

daschaa commented Jun 2, 2022

daschaa commented Jun 3, 2022

mergify bot commented Jun 3, 2022

aws-cdk-automation commented Jun 3, 2022

AWS CodeBuild CI Report

mergify bot commented Jun 3, 2022

daschaa commented May 2, 2022 •

edited

Loading