Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sagemaker): add model hosting L2 constructs #20113

Closed
wants to merge 65 commits into from

Conversation

petermeansrock
Copy link
Contributor

@petermeansrock petermeansrock commented Apr 28, 2022

Based closely on PR #2888, this commit introduces the Endpoint L2
construct and the L2 constructs on which it depends, including Model and
EndpointConfig. Departures from PR #2888 include:

  • EndpointConfig definition moved into its own L2 construct as one
    EndpointConfig resource may be shared by multiple Endpoints.
  • An Endpoint-specific IEndpointProductionVariant interface was added to
    support "metric*" and "autoScale*" APIs per endpoint-variant
    combination.
  • The Notebook construct was excluded from this new commit to limit
    changes to model hosting use-cases only.
  • Feedback on the earlier PR has been incorporated into this new commit.

fixes #2809

Co-authored-by: Matt McClean [email protected]
Co-authored-by: Long Yao [email protected]
Co-authored-by: Drew Jetter [email protected]
Co-authored-by: Murali Ganesh [email protected]
Co-authored-by: Abilash Rangoju [email protected]


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

petermeansrock and others added 25 commits February 4, 2020 10:32
Based closely on PR aws#2888, this commit introduces the Endpoint L2
construct and the L2 constructs on which it depends, including Model and
EndpointConfig. Departures from PR aws#2888 include:
- EndpointConfig definition moved into its own L2 construct as one
  EndpointConfig resource may be shared by multiple Endpoints.
- An Endpoint-specific IEndpointProductionVariant interface was added to
  support "metric*" and "autoScale*" APIs per endpoint-variant
  combination.
- The Notebook construct was excluded from this new commit to limit
  changes to model hosting use-cases only.
- Feedback on the earlier PR has been incorporated into this new commit.

fixes aws#2809

Co-authored-by: Matt McClean <[email protected]>
Co-authored-by: Yao <[email protected]>
Co-authored-by: Drew Jetter <[email protected]>
Co-authored-by: Murali Ganesh <[email protected]>
Co-authored-by: Abilash Rangoju <[email protected]>
@gitpod-io
Copy link

gitpod-io bot commented Apr 28, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team April 28, 2022 00:40
@github-actions github-actions bot added effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p2 labels Apr 28, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e0741ff
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@petermeansrock
Copy link
Contributor Author

The RFC associated with this PR has been approved and merged, and the API bar raiser has asked me to break the implementation down into a smaller set of PRs, covering the L2 constructs for Model, EndpointConfig, and Endpoint each in their own PR. Now that the new Model PR has been published, I'm going to close this PR to avoid confusion. Issue #2809 continues to be the best place to track the addition of these model hosting constructs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sagemaker: Create L2 construct for Amazon SageMaker
4 participants