Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(glue): add L2 resources for
Database
andTable
#1988feat(glue): add L2 resources for
Database
andTable
#1988Changes from 6 commits
3551d75
3de3b03
e4df159
502b0cb
a08dc37
f4db178
0d10989
cf6d56d
9dc8e57
c7f62d7
e0043a9
231c36a
cee2e46
4595fde
b8f886b
db1960b
d245b1c
f98d5fd
d3ccd53
538cff9
0c2f7fa
1cb7c4f
a5d45f0
30f8a3c
45434fe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering, if
name
is unique, why not use a hash?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two semantics we want to model as strictly as we can: column uniqueness and ordering.
node.js
, the order of variables is the order in which they are added to the object, but that is not the case for other languages likejava
, where a developer would have to know to use aLinkedHashMap
.I chose to statically model the ordering property with an
array
and check the uniqueness at runtime because then, at least the experience is consistent for all consumers. Using a hash might create confusion for consumers - they would not receive an error, the layout of their columns could just change arbitrarily.