feat(ecs): add external network modes to ExternalTaskDefinition and TaskDefinition

packages/@aws-cdk/aws-ecs/lib/base/task-definition.ts

@@ -401,8 +401,8 @@ export class TaskDefinition extends TaskDefinitionBase {
       throw new Error('Cannot use inference accelerators on tasks that run on Fargate');
     }
 
-    if (this.isExternalCompatible && this.networkMode !== NetworkMode.BRIDGE) {
-      throw new Error(`External tasks can only have Bridge network mode, got: ${this.networkMode}`);
+    if (this.isExternalCompatible && ![NetworkMode.BRIDGE, NetworkMode.HOST, NetworkMode.NONE].includes(this.networkMode)) {
+      throw new Error(`External tasks can only have Bridge, Host or None network mode, got: ${this.networkMode}`);
     }
 
     this._executionRole = props.executionRole;

packages/@aws-cdk/aws-ecs/lib/external/external-task-definition.ts

@@ -15,7 +15,14 @@ import {
  * The properties for a task definition run on an External cluster.
  */
 export interface ExternalTaskDefinitionProps extends CommonTaskDefinitionProps {
-
+  /**
+   * The networking mode to use for the containers in the task.
+   *
+   * With ECS Anywhere, supported modes are bridge, host and none.
+   *
+   * @default - NetworkMode.Bridge
+   */
+  readonly networkMode?: NetworkMode;
 }
 
 /**
@@ -38,7 +45,6 @@ export interface ExternalTaskDefinitionAttributes extends CommonTaskDefinitionAt
  * @resource AWS::ECS::TaskDefinition
  */
 export class ExternalTaskDefinition extends TaskDefinition implements IExternalTaskDefinition {
-
   /**
    * Imports a task definition from the specified task definition ARN.
    */
@@ -59,20 +65,27 @@ export class ExternalTaskDefinition extends TaskDefinition implements IExternalT
     return new ImportedTaskDefinition(scope, id, {
       taskDefinitionArn: attrs.taskDefinitionArn,
       compatibility: Compatibility.EXTERNAL,
-      networkMode: NetworkMode.BRIDGE,
+      networkMode: attrs.networkMode,
       taskRole: attrs.taskRole,
     });
   }
 
+  /**
+   * The networking mode to use for the containers in the task.
+   */
+  public readonly networkMode: NetworkMode;
+
   /**
    * Constructs a new instance of the ExternalTaskDefinition class.
    */
   constructor(scope: Construct, id: string, props: ExternalTaskDefinitionProps = {}) {
     super(scope, id, {
       ...props,
       compatibility: Compatibility.EXTERNAL,
-      networkMode: NetworkMode.BRIDGE,
+      networkMode: (props.networkMode ?? NetworkMode.BRIDGE),
     });
+
+    this.networkMode = props.networkMode ?? NetworkMode.BRIDGE;
   }
 
   /**

packages/@aws-cdk/aws-ecs/test/external/external-task-definition.test.ts

@@ -7,6 +7,7 @@ import * as secretsmanager from '@aws-cdk/aws-secretsmanager';
 import * as ssm from '@aws-cdk/aws-ssm';
 import * as cdk from '@aws-cdk/core';
 import * as ecs from '../../lib';
+import { NetworkMode } from '../../lib';
 
 describe('external task definition', () => {
   describe('When creating an External TaskDefinition', () => {
@@ -37,6 +38,7 @@ describe('external task definition', () => {
           ),
         }),
         family: 'ecs-tasks',
+        networkMode: NetworkMode.HOST,
         taskRole: new iam.Role(stack, 'TaskRole', {
           assumedBy: new iam.ServicePrincipal('ecs-tasks.amazonaws.com'),
         }),
@@ -51,7 +53,7 @@ describe('external task definition', () => {
           ],
         },
         Family: 'ecs-tasks',
-        NetworkMode: ecs.NetworkMode.BRIDGE,
+        NetworkMode: ecs.NetworkMode.HOST,
         RequiresCompatibilities: [
           'EXTERNAL',
         ],
@@ -66,6 +68,18 @@ describe('external task definition', () => {
 
     });
 
+    test('error when an invalid networkmode is set', () => {
+      // GIVEN
+      const stack = new cdk.Stack();
+
+      // THEN
+      expect(() => {
+        new ecs.ExternalTaskDefinition(stack, 'ExternalTaskDef', {
+          networkMode: NetworkMode.AWS_VPC,
+        });
+      }).toThrow('External tasks can only have Bridge, Host or None network mode, got: awsvpc');
+    });
+
     test('correctly sets containers', () => {
       // GIVEN
       const stack = new cdk.Stack();

packages/@aws-cdk/aws-ecs/test/task-definition.test.ts

@@ -5,7 +5,7 @@ import * as ecs from '../lib';
 
 describe('task definition', () => {
   describe('When creating a new TaskDefinition', () => {
-    test('A task definition with both compatibilities defaults to networkmode AwsVpc', () => {
+    test('A task definition with EC2 and Fargate compatibilities defaults to networkmode AwsVpc', () => {
       // GIVEN
       const stack = new cdk.Stack();
 
@@ -23,6 +23,23 @@ describe('task definition', () => {
 
 
     });
+
+    test('A task definition with External compatibility defaults to networkmode Bridge', () => {
+      // GIVEN
+      const stack = new cdk.Stack();
+
+      // WHEN
+      new ecs.TaskDefinition(stack, 'TD', {
+        cpu: '512',
+        memoryMiB: '512',
+        compatibility: ecs.Compatibility.EXTERNAL,
+      });
+
+      //THEN
+      expect(stack).toHaveResource('AWS::ECS::TaskDefinition', {
+        NetworkMode: 'bridge',
+      });
+    });
   });
 
   describe('When importing from an existing Task definition', () => {